From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1A96A0613 for ; Wed, 25 Sep 2019 08:37:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8FD832BB5; Wed, 25 Sep 2019 08:37:27 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 54A909E4 for ; Wed, 25 Sep 2019 08:37:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2019 23:37:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,546,1559545200"; d="scan'208";a="364233769" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 24 Sep 2019 23:37:24 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 23:37:24 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 23:37:23 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.146]) with mapi id 14.03.0439.000; Wed, 25 Sep 2019 14:37:21 +0800 From: "Cao, Yahui" To: "Gavin Hu (Arm Technology China)" , "Yang, Qiming" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "Zhang, Qi Z" , "Ye, Xiaolong" , "Xing, Beilei" , nd Thread-Topic: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine Thread-Index: AQHVcuGMKPLH5ci+YkaEt/BYO/5Fnac7NFSAgAC8BJA= Date: Wed, 25 Sep 2019 06:37:20 +0000 Message-ID: <69D26CF227A0D2439032A967C0D64F5C0C49BDE5@SHSMSX101.ccr.corp.intel.com> References: <20190924215243.81474-1-yahui.cao@intel.com> <20190924215243.81474-2-yahui.cao@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDAyZGJkMjgtYjU4NS00ZWIyLTg0MjctOGYzYmE5NzM3MmFjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibTNyOTlqeDd3OGM4QkF1cSt3enU2dmRRVWtQRlhZcUYrK1BsWWM2XC9YaEZkV213b0FkdmlhTnU0ZmVWd01Hb1IifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks for the comments. Old version patches' states are changed. -----Original Message----- From: Gavin Hu (Arm Technology China) [mailto:Gavin.Hu@arm.com]=20 Sent: Wednesday, September 25, 2019 11:20 AM To: Cao, Yahui ; Yang, Qiming ;= Lu, Wenzhuo Cc: dev@dpdk.org; Zhang, Qi Z ; Ye, Xiaolong ; Xing, Beilei ; nd Subject: RE: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine Hi Yahui, two general comments:=20 1.Please make old versions of patches Superseded to facilitate review. 2. the two occurrences of rte_wmb can be removed, a similar patch has been = reviewed by Qi. http://patches.dpdk.org/patch/59278/=20 /Gavin > -----Original Message----- > From: dev On Behalf Of Yahui Cao > Sent: Wednesday, September 25, 2019 5:53 AM > To: Qiming Yang ; Wenzhuo Lu=20 > > Cc: dev@dpdk.org; Qi Zhang ; Xiaolong Ye=20 > ; Beilei Xing ; Yahui=20 > Cao > Subject: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director=20 > engine >=20 > From: Beilei Xing >=20 > Enable flow director engine, including initialization and teardown. > - Control VSI create and release. > - Queue pair allocated, set up and release. > - Programming packet create and release. > - FDIR profile create and release. >=20 > Signed-off-by: Beilei Xing > ---