From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/txgbe: remove direct use of compiler attribute
Date: Mon, 9 Nov 2020 19:18:39 +0000 [thread overview]
Message-ID: <69bbfac6-8357-b55b-2426-5e658eef32b9@intel.com> (raw)
In-Reply-To: <20201109074346.3896752-1-jiawenwu@trustnetic.com>
On 11/9/2020 7:43 AM, Jiawen Wu wrote:
> Remove direct use of compiler attribute.
>
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> ---
> drivers/net/txgbe/base/txgbe_dummy.h | 2 +-
> drivers/net/txgbe/base/txgbe_osdep.h | 6 ++----
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/txgbe/base/txgbe_dummy.h b/drivers/net/txgbe/base/txgbe_dummy.h
> index 0a3a76d0c..3a667dd31 100644
> --- a/drivers/net/txgbe/base/txgbe_dummy.h
> +++ b/drivers/net/txgbe/base/txgbe_dummy.h
> @@ -7,7 +7,7 @@
>
> #ifdef TUP
> #elif defined(__GNUC__)
> -#define TUP(x) x##_unused __attribute__((unused))
> +#define TUP(x) (x##_unused txgbe_unused)
Because of build error, removing parenthesis while applying, please double check
ci build results of the patches [1] and send new version if required.
Were there any specific reason for the parenthesis, am I missing something there?
[1]
http://mails.dpdk.org/archives/test-report/2020-November/165922.html
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2020-11-09 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 7:43 Jiawen Wu
2020-11-09 19:18 ` Ferruh Yigit [this message]
2020-11-10 2:09 ` Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69bbfac6-8357-b55b-2426-5e658eef32b9@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).