From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCDB9A0527; Mon, 9 Nov 2020 20:18:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2ADF697C; Mon, 9 Nov 2020 20:18:48 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 66389697B for ; Mon, 9 Nov 2020 20:18:47 +0100 (CET) IronPort-SDR: z0XDOtIwZ/XZi43KpkMlRydqTb3TdYiAJVaNazYCG9e9A9oGUVF4KiUGS8I3Ih2cDjbQbkzrPA ldKcV7vk6W8g== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="187811919" X-IronPort-AV: E=Sophos;i="5.77,464,1596524400"; d="scan'208";a="187811919" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 11:18:43 -0800 IronPort-SDR: rCec/iJVu3cZtIJ1bhVNh0ZMItmGWKVXXzQPxWfx9UG27LCAHb+ijMPbhCOJi0zRbbN24z4BDX ZPchxYc5gtOw== X-IronPort-AV: E=Sophos;i="5.77,464,1596524400"; d="scan'208";a="530879134" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.193.177]) ([10.213.193.177]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 11:18:42 -0800 To: Jiawen Wu , dev@dpdk.org References: <20201109074346.3896752-1-jiawenwu@trustnetic.com> From: Ferruh Yigit Message-ID: <69bbfac6-8357-b55b-2426-5e658eef32b9@intel.com> Date: Mon, 9 Nov 2020 19:18:39 +0000 MIME-Version: 1.0 In-Reply-To: <20201109074346.3896752-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/txgbe: remove direct use of compiler attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/9/2020 7:43 AM, Jiawen Wu wrote: > Remove direct use of compiler attribute. > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/base/txgbe_dummy.h | 2 +- > drivers/net/txgbe/base/txgbe_osdep.h | 6 ++---- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/txgbe/base/txgbe_dummy.h b/drivers/net/txgbe/base/txgbe_dummy.h > index 0a3a76d0c..3a667dd31 100644 > --- a/drivers/net/txgbe/base/txgbe_dummy.h > +++ b/drivers/net/txgbe/base/txgbe_dummy.h > @@ -7,7 +7,7 @@ > > #ifdef TUP > #elif defined(__GNUC__) > -#define TUP(x) x##_unused __attribute__((unused)) > +#define TUP(x) (x##_unused txgbe_unused) Because of build error, removing parenthesis while applying, please double check ci build results of the patches [1] and send new version if required. Were there any specific reason for the parenthesis, am I missing something there? [1] http://mails.dpdk.org/archives/test-report/2020-November/165922.html Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.