From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) by dpdk.org (Postfix) with ESMTP id B23C27D14 for ; Fri, 25 Aug 2017 02:55:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1394; q=dns/txt; s=iport; t=1503622523; x=1504832123; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=UlBGi+gfdpDqWcY/E6VANXkXfbj1pcSaVUXQcaLxYoY=; b=Jk3EsAGVn1vHzD/Ywe70mx+NKhjr4OU+YqKZEgz9HVHCFvUaiODXK3qP DtaqGnIHB8NqpypzQ9brtPRQa2Ztgqaym+wN6z+l4v9LIlkx2AjxxjQ// Oj4cHX9blw8r1ILDfhDRxEekiGOZZ4fXi59SpmZ4ZQpDo38W3HvIE/Cb/ Y=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0C8AQBedJ9Z/4gNJK1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1qBeQeeJYFwkUGGdoVHAoRSQxQBAgEBAQEBAQFrKIUYAQEBAQM?= =?us-ascii?q?6PwwEAgEIEQQBAQEeCQcyFAkIAgQOBQiKKa9ni2EBAQEBAQEBAQEBAQEBAQEBA?= =?us-ascii?q?QEBAQEdgyqCAoFMhQqKZwWgWQKUOpJtSJVnATYhgQp3FYVgHIFndgGJBoEPAQE?= =?us-ascii?q?B?= X-IronPort-AV: E=Sophos;i="5.41,423,1498521600"; d="scan'208";a="285239011" Received: from alln-core-3.cisco.com ([173.36.13.136]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 25 Aug 2017 00:55:22 +0000 Received: from XCH-ALN-008.cisco.com (xch-aln-008.cisco.com [173.36.7.18]) by alln-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id v7P0tMrA025798 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 25 Aug 2017 00:55:22 GMT Received: from xch-rcd-016.cisco.com (173.37.102.26) by XCH-ALN-008.cisco.com (173.36.7.18) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 24 Aug 2017 19:55:21 -0500 Received: from xch-rcd-016.cisco.com ([173.37.102.26]) by XCH-RCD-016.cisco.com ([173.37.102.26]) with mapi id 15.00.1210.000; Thu, 24 Aug 2017 19:55:21 -0500 From: "David Harton (dharton)" To: Stephen Hemminger CC: "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "stephen.hurd@broadcom.com" , "ajit.khaparde@broadcom.com" , "John Daley (johndale)" , "wenzhuo.lu@intel.com" , "konstantin.ananyev@intel.com" , "jingjing.wu@intel.com" , "beilei.xing@intel.com" , "jing.d.chen@intel.com" , "adrien.mazarguil@6wind.com" , "nelio.laranjeiro@6wind.com" , "alejandro.lucero@netronome.com" , "hemant.agrawal@nxp.com" , "rasesh.mody@cavium.com" , "harish.patil@cavium.com" , "skhare@vmware.com" , "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" , "allain.legacy@windriver.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] ethdev: modifiy vlan_offload_set_t to return int Thread-Index: AQHTHS9cuSIDgWJRREabFtLkc0B9GaKUfT8A///AkOA= Date: Fri, 25 Aug 2017 00:55:21 +0000 Message-ID: <69ca37d9a8014b49bfb5b156f98eba03@XCH-RCD-016.cisco.com> References: <20170824231851.21829-1-dharton@cisco.com> <20170824163708.2931e83b@xeon-e3> In-Reply-To: <20170824163708.2931e83b@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.82.245.208] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: modifiy vlan_offload_set_t to return int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 00:55:24 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Thursday, August 24, 2017 7:37 PM > To: David Harton (dharton) > Cc: thomas@monjalon.net; ferruh.yigit@intel.com; > stephen.hurd@broadcom.com; ajit.khaparde@broadcom.com; John Daley > (johndale) ; wenzhuo.lu@intel.com; > konstantin.ananyev@intel.com; jingjing.wu@intel.com; > beilei.xing@intel.com; jing.d.chen@intel.com; adrien.mazarguil@6wind.com; > nelio.laranjeiro@6wind.com; alejandro.lucero@netronome.com; > hemant.agrawal@nxp.com; rasesh.mody@cavium.com; harish.patil@cavium.com; > skhare@vmware.com; yliu@fridaylinux.org; maxime.coquelin@redhat.com; > allain.legacy@windriver.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ethdev: modifiy vlan_offload_set_t to > return int >=20 > On Thu, 24 Aug 2017 19:18:51 -0400 > David Harton wrote: >=20 > > @@ -2031,7 +2031,7 @@ struct avp_queue { > > mask =3D (ETH_VLAN_STRIP_MASK | > > ETH_VLAN_FILTER_MASK | > > ETH_VLAN_EXTEND_MASK); > > - avp_vlan_offload_set(eth_dev, mask); > > + (void)avp_vlan_offload_set(eth_dev, mask); >=20 > This is a BSDism. You don't need the void cast. Never know what to do...SA tools and some compilers whine if I don't. People complain if I do. :) What if I check the return code and log an error?=20