From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Long Li <longli@microsoft.com>,
Ophir Munk <ophirmu@nvidia.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] tap: fix build of TAP BPF program
Date: Fri, 21 Jul 2023 14:05:52 +0100 [thread overview]
Message-ID: <69cfb305-7673-f026-e2b2-cc7cbf78ddde@amd.com> (raw)
In-Reply-To: <20230720232549.63619-1-stephen@networkplumber.org>
On 7/21/2023 12:25 AM, Stephen Hemminger wrote:
> Move the BPF program related code into a subdirectory.
> And add a Makefile for building it.
>
> The code was depending on old versions of headers from iproute2.
> Include those headers here so that build works.
>
Thanks Stephen, build works now.
But I am not sure about importing dependent headers to DPDK, could build
work with latest external headers if application updated accordingly?
> The standalone build was also broken because by
> commit ef5baf3486e0 ("replace packed attributes")
> which introduced __rte_packed into this code.
>
> Add a python program to extract the resulting BPF into
> a format that can be consumed by the TAP driver.
>
> Update the documentation.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
<...>
> --- /dev/null
> +++ b/drivers/net/tap/bpf/bpf_api.h
> @@ -0,0 +1,261 @@
> +#ifndef __BPF_API__
> +#define __BPF_API__
> +
What should be License and Copyright of these files?
Same for all imported headers.
next prev parent reply other threads:[~2023-07-21 13:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-16 21:25 [RFC] MAINTAINERS: add status information Stephen Hemminger
2023-07-19 16:07 ` [PATCH v2] " Stephen Hemminger
2023-07-20 17:21 ` [PATCH v3] " Stephen Hemminger
2023-07-20 17:45 ` [PATCH v2 ] tap: fix build of TAP BPF program Stephen Hemminger
2023-07-20 23:25 ` [PATCH v3] " Stephen Hemminger
2023-07-21 13:05 ` Ferruh Yigit [this message]
2023-07-21 15:43 ` Stephen Hemminger
2023-07-23 2:21 ` Stephen Hemminger
2023-07-26 16:31 ` Stephen Hemminger
2023-07-22 16:32 ` [PATCH v4] " Stephen Hemminger
2023-10-31 22:08 ` [PATCH 0/3] net/tap: update and fix the " Stephen Hemminger
2023-10-31 22:08 ` [PATCH 1/3] net/tap: support infrastructure to build the BPF filter Stephen Hemminger
2023-10-31 22:08 ` [PATCH 2/3] net/tap: Fixed RSS algorithm to support fragmented packets Stephen Hemminger
2023-10-31 22:08 ` [PATCH 3/3] net/tap; rebuild and update the BPF flow program Stephen Hemminger
2023-10-31 22:42 ` [PATCH v5 0/3] net/tap: build and fix for BPF program Stephen Hemminger
2023-10-31 22:42 ` [PATCH v5 1/3] net/tap: support infrastructure to build the BPF filter Stephen Hemminger
2023-10-31 22:42 ` [PATCH v5 2/3] net/tap: Fixed RSS algorithm to support fragmented packets Stephen Hemminger
2023-10-31 22:42 ` [PATCH v5 3/3] net/tap; rebuild and update the BPF flow program Stephen Hemminger
2023-11-01 18:02 ` [PATCH v6 0/3] net/tap: build and fix for BPF program Stephen Hemminger
2023-11-01 18:02 ` [PATCH v6 1/3] net/tap: support infrastructure to build the BPF filter Stephen Hemminger
2023-11-01 18:02 ` [PATCH v6 2/3] net/tap: Fixed RSS algorithm to support fragmented packets Stephen Hemminger
2023-11-01 18:02 ` [PATCH v6 3/3] net/tap; rebuild and update the BPF flow program Stephen Hemminger
2023-11-02 15:13 ` Ferruh Yigit
2023-11-02 16:53 ` Stephen Hemminger
2023-11-02 18:25 ` Ferruh Yigit
2023-11-02 21:00 ` Ferruh Yigit
2023-11-02 21:56 ` Stephen Hemminger
2023-11-02 15:11 ` [PATCH v6 0/3] net/tap: build and fix for BPF program Ferruh Yigit
2023-11-02 16:52 ` Stephen Hemminger
2023-11-02 16:52 ` Stephen Hemminger
2023-11-02 18:35 ` Ferruh Yigit
2023-11-02 18:39 ` Stephen Hemminger
2023-11-02 15:21 ` Ferruh Yigit
2023-11-03 3:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69cfb305-7673-f026-e2b2-cc7cbf78ddde@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=longli@microsoft.com \
--cc=ophirmu@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).