From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8DF5542EDA;
Fri, 21 Jul 2023 15:06:02 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1BBC640E2D;
Fri, 21 Jul 2023 15:06:02 +0200 (CEST)
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
(mail-co1nam11on2055.outbound.protection.outlook.com [40.107.220.55])
by mails.dpdk.org (Postfix) with ESMTP id 8189440DDC
for <dev@dpdk.org>; Fri, 21 Jul 2023 15:06:00 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Lznd5VF8mdN55sPbRQSZnGzPyxdim/7Hy8gCRCF0jHnqegLYyMG3fQCppMGCFz7r6AnKHtoREWp1ZZq6PbcwPQU4cqIWHfWnO+G/U8h2QjSYe3UGnF7yvdpnBcd5dYxZokUMKpqtz/LeDYHA0XftyGAygw2WSAydzYhqbkn8qw9gfXrTOIjkgL6X7IEDnusoYf2Ys7YuE+nuFVqnGKz/qzbVoIq+prfSrJ0/cVGhY9WbjFPgELqPACnuoTM3eF7Jezoot3ojtd2PvZksdPLNuLESUQSRwQDFZQv7+EblOg0WR39XYZlLr88nQdIUPvkZm96/cjtXpJjijPQ07kq7tQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=nmLqJpL/sETLzJG10Mc/x4PM5pem6eMtEn8dBDp9e0Y=;
b=LDpVPZBMNaoq+QhwjPTlB6oCuFFpRYD2zq2Aexa8T6jFCZ3xx2DYEifexqm+G0sr/Q7XDt/g13K3tlg96JtHufWqB6P6+KQFtdAa7I0S+AwJJTvrgcCirEyfX/hA99Ts1KztHkc3vTOhJSKWXgYoHdu36+FQht9F+viNr1oUWq36qd7PSEVxdMwZCI14jviLqlnp4THrlgcNmDuU7dL+kx/R4mWm9/xbSxwKJcdMi7xrEwhNbyaDSgjg4ZaNCDFKKOea71ycmeFkgeXoJOjmUY7Or35Q8oepLtT34kuleqKqCYv3f+1QjEaydZCMVPTXH+wg40Dx5VI3lH4QuDhuXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=nmLqJpL/sETLzJG10Mc/x4PM5pem6eMtEn8dBDp9e0Y=;
b=CC8xBcpUGVLYkrPdiVMDS7pDWAR2t4T0wWlBC9euX5nKQbtxEdt7HVESrwiDQKZGSEIWJLHN82d89+Zzvtti8sGAFivnUONn1yGz8J8pmJtJEMJLZhpJzPBoUcnRRgwOkEBiMZvf9yC1RIlV85uGsuWY7xca2raU7DZHm33dzRw=
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=amd.com;
Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11)
by DM6PR12MB4563.namprd12.prod.outlook.com (2603:10b6:5:28e::10) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul
2023 13:05:58 +0000
Received: from CH2PR12MB4294.namprd12.prod.outlook.com
([fe80::15a9:4e83:4217:8b49]) by CH2PR12MB4294.namprd12.prod.outlook.com
([fe80::15a9:4e83:4217:8b49%7]) with mapi id 15.20.6609.026; Fri, 21 Jul 2023
13:05:58 +0000
Message-ID: <69cfb305-7673-f026-e2b2-cc7cbf78ddde@amd.com>
Date: Fri, 21 Jul 2023 14:05:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
Thunderbird/102.13.0
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>
References: <20230716212544.5625-1-stephen@networkplumber.org>
<20230720232549.63619-1-stephen@networkplumber.org>
From: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org, Long Li <longli@microsoft.com>,
Ophir Munk <ophirmu@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] tap: fix build of TAP BPF program
In-Reply-To: <20230720232549.63619-1-stephen@networkplumber.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: PA7P264CA0031.FRAP264.PROD.OUTLOOK.COM
(2603:10a6:102:34b::13) To CH2PR12MB4294.namprd12.prod.outlook.com
(2603:10b6:610:a9::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4563:EE_
X-MS-Office365-Filtering-Correlation-Id: dbd15624-fbcf-47bb-c0ad-08db89eb39a3
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: gUwC9t7hQbSLPn1ub/TxquuYU22OeXOQFynJwvL8gpHZn5HuVUCRfwM78M/8HlovwQ8VLimLcJoQbM3I5GXo0ozxRiIlmQphTpWVohLW71CWV+GDdYrDFoVUe+Qew/AMFYWzzF7s6+TXVNEf/jKDLN7yplbK8yMm3c2ejw7wD3tT6xPjALKmWGSs5YXSrIgmRiwIIy/Pv+crrHcKq1pgczojvcM+CMCOJ7989ZCrN9LwHowEtZEj55+ixz5UupNewODmTwOI/iyqmd9LsxPwg90PojYZVZ9v9sEn7ahNswTuNcEJ372sVzDV+n1HWL4Vb2khK2Fxx4/pXFp22TmLnyVHebS4RjAq6Ej17IFupp4Ro0DS7AKuj/ud6BOOU1pDsxZCVrqAVCEx3qd+9GaSjyy8wHhgPR+YqAFDyOYM69eL0g6sQC2tiypXFsazQJfdbUfeBKPPbp3Gaw9amgpHdwf3taWxSqDUN2x0k3xB3HcA/lw/WtRWJuunocqzyURKf5flcGsith5WMnBDKiKFO2BQyKzvdFMEHG6XBUw8X1ht55kRGB9XcNkOCUhkAgRPeV1mmwwbkb2wyNQqr9D7+62grGsmZzIbA33XA51APl/peUbCc8y4I8G5t8JTpExe6YzHI+YIkGa31ZbbRlSthw==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230028)(4636009)(366004)(376002)(39860400002)(396003)(136003)(346002)(451199021)(53546011)(36756003)(54906003)(478600001)(6666004)(6512007)(6486002)(6506007)(26005)(186003)(86362001)(31696002)(6916009)(66946007)(66556008)(44832011)(66476007)(316002)(31686004)(4326008)(8936002)(38100700002)(8676002)(5660300002)(2616005)(2906002)(41300700001)(83380400001)(43740500002)(45980500001);
DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzMrOHVzRFhkUGRZWG9NdlNDVmNqYm81OUY1aVJzRytOZ09xb2p5OWFoYjBB?=
=?utf-8?B?Tnh5QUJSb1VKWVN2V01aRllXZHREdkgrRk9CbE5NQ1BSMXpvQW9oME1GTncw?=
=?utf-8?B?cnRRV0M5YlJIVGxDV1pkMlFaYjRGTk55S0wxN3RKd0JqSEF0amxJdjRHZFNK?=
=?utf-8?B?Y2lXWldha2NHOGRVOGRoUXduMmtDTU5Xemo2TFNnMjJtTGQ5MGw4SndFQmJS?=
=?utf-8?B?TjVPY2NWVkc0NWFwSURoRmNGdFBrMzR4empvcmtqUk1FOTFBQmRSZFRlUTdP?=
=?utf-8?B?S0V4SlYvRE90ZEhhRi94NjdnSUt2dldkOThwTkdGRXdkT2lzS0pkb2c2Ukwx?=
=?utf-8?B?aDRtM0dpQ2p6aDlJR1Fya2lZb3lDTVVwdndLWnBsWllGZkFWaUVYZVdyNFNY?=
=?utf-8?B?andwYWM5dVFqTDdRVkxpazBzM1NGRnQ1TG9ZUW5oQzRGNjZoaFplai9oaDEv?=
=?utf-8?B?cDd6RTBYVEdxaDVWbXhuUHhMa0JvZXQraldocnFWNG95ejlwNjNIbkNqSnR2?=
=?utf-8?B?K2tkYTRMdkJCZ1hMN2pla3N5UTZwem9BemxOMXlNeFQ1Tzk1Tnc1T2hjOHlx?=
=?utf-8?B?SlF4cFptWGRzYXJHYkkrUFQwK2s1OHZZMW83aHZiQStmRGVTTC9kMENUWmJU?=
=?utf-8?B?T1o5TGxoZ2MwdGNMRHhkVVBuUC9FR0NjRUtOaW5MYnNrTVBHZHh6a3d5RUF3?=
=?utf-8?B?UHoxeXRSMDQ1Y3gxdUtmZEhoeVR1RkVnVEpXenphbFdwNVNidVMrdy9QU0ZM?=
=?utf-8?B?WFV6UFltTG5iMStpTEgyemRpNTBSaElHdnFNSkZLeUpNekt4NjVRMjh2S0Nu?=
=?utf-8?B?Rkg0UTN1OVcvMzVadXJFRm5mZUhSYTVmTlp5V2ovajd1cjNMbDlzdnQ5ZDJs?=
=?utf-8?B?U08xTVJWdEtyVVRHYXhMV3dyNWRvYjBscnpZN0duRlVNZ0dGQ21YcnpCazNh?=
=?utf-8?B?Sm52R3ZFRkpyQzkxTVlwN212aDJESFBjTVhTMXU5R0puMEtLcjErQTZERXJM?=
=?utf-8?B?SVdPQ1ZXZjh2anFkRy9tZUs4TWl4L2lJamp5YzBEa0hDYVpLYVQzNGdyanlY?=
=?utf-8?B?bUloOUFrSm5HZmE3S0gyYVhmcUhGeHhCSnRUUDN4T3BnVHp1dEVkeTNOcHcx?=
=?utf-8?B?cmV5K0xselJHcVdwanArTlRrUDhyTVVSN0grZDU1NXJ5UWl4cE5qeFhCeFpw?=
=?utf-8?B?YjZqWnExVldLOW1oYWcrc2RSVzlxSlordlBJdTlreVBvcEFaVDJRTTc1cFA4?=
=?utf-8?B?cGRkL0EwM0VrR2NrTDEyTFVtTmIyKzRuQjRsWUxYemw5Uk0yRmtNSEl5bEZz?=
=?utf-8?B?aTFWdUxaZWZ2c0tEd09vR1Z6WERqdHdpRDE4YVYrTTllc0s3K00wUUUxZGVL?=
=?utf-8?B?MXhERktDY0p4TmovQ2kzV1FiSHA4cEZVN1N1cXZITFFDUVhSNEFEOU8xa3N2?=
=?utf-8?B?NVowZVFmZndQWTBrNHZLLzkraVRQNG4vWVFqYTJnbkh1VG95djJ3RHovUzN6?=
=?utf-8?B?Y3FQNktHcDFVTmpybFdqQjVtWk9oMnJxakFaci9ZN0kyRnZMa1dKUDlSc202?=
=?utf-8?B?M29yeXJzb2h3M0R0RFNhdmF0VXg3V0xqbW9qMHZydnk1ekRaenZnMDVMMVd6?=
=?utf-8?B?Vy8zWW1VT2tiZTB4OUtvMHloRTVvZE9LQWtwY0hkRVY4YUk3dXl4S2VwOThs?=
=?utf-8?B?VGlWcU02azY1T0s5UTFZV3lHa1hDblNhZ0NQQnE2N2o4ODJhalR0R0poZGpI?=
=?utf-8?B?QVRubVU2STFxT0FQUGFTUmFJS2d0Vy9lZ3hkWVhjY0UycDBYQTREK0kwOENs?=
=?utf-8?B?VlF4bE1wQVI3bXN1VzNyMzJvTlJvcFRvdVBHQVVsbyt2VGJPbDNkN0pYT2ZD?=
=?utf-8?B?cUZGSVBYN2dCUDlZUFdLZnFsNXl2MkRzTW0xN3Nab01Fdi9uNXlvVUhpUkV0?=
=?utf-8?B?ZWswYUJMWnA4RWxVSTlNWVNDYUhEQzJJYTBxZ3I4Q0lSQjlHd0hzb0x3WDFZ?=
=?utf-8?B?ZVpLWWR4U01VS0lSVGJjbyt0ZnlCdUtMSmlhbFJuZjRmM3VmUEJ1VmJJT0Zx?=
=?utf-8?B?blREVFZxcTNwR3FUZllZRS9IVG4rdFAxM1ZQZ05qbEdOemtsVFJXMVZjencr?=
=?utf-8?Q?JH97NdUYarugobqdUlxlCDa0G?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dbd15624-fbcf-47bb-c0ad-08db89eb39a3
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 13:05:58.2603 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QlVsMjsD6MzxzkHu3b0YDROlCvWJXxKUGbcLXVhRFNqf331jdbxDX6fRC3qfVRnE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4563
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 7/21/2023 12:25 AM, Stephen Hemminger wrote:
> Move the BPF program related code into a subdirectory.
> And add a Makefile for building it.
>
> The code was depending on old versions of headers from iproute2.
> Include those headers here so that build works.
>
Thanks Stephen, build works now.
But I am not sure about importing dependent headers to DPDK, could build
work with latest external headers if application updated accordingly?
> The standalone build was also broken because by
> commit ef5baf3486e0 ("replace packed attributes")
> which introduced __rte_packed into this code.
>
> Add a python program to extract the resulting BPF into
> a format that can be consumed by the TAP driver.
>
> Update the documentation.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
<...>
> --- /dev/null
> +++ b/drivers/net/tap/bpf/bpf_api.h
> @@ -0,0 +1,261 @@
> +#ifndef __BPF_API__
> +#define __BPF_API__
> +
What should be License and Copyright of these files?
Same for all imported headers.