From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28266A00BE; Mon, 7 Mar 2022 02:05:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CD574116D; Mon, 7 Mar 2022 02:05:25 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id DE33A4115F; Mon, 7 Mar 2022 02:05:22 +0100 (CET) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KBg9v0hVKzbc20; Mon, 7 Mar 2022 09:00:35 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Mon, 7 Mar 2022 09:05:20 +0800 Subject: Re: [PATCH v5] app/testpmd: add help messages for multi-process To: Thomas Monjalon , "Zhang, Yuying" CC: "dev@dpdk.org" , Huisong Li , "stable@dpdk.org" , "Li, Xiaoyun" , "Singh, Aman Deep" , Ajit Khaparde , Andrew Rybchenko , Ferruh Yigit References: <20220228032617.46618-1-humin29@huawei.com> <1a9abf77-b0ed-d454-2c41-cca738712e08@intel.com> <5269403.vfdyTQepKt@thomas> From: "Min Hu (Connor)" Message-ID: <69f6755e-f101-d339-90ee-2843b265f68c@huawei.com> Date: Mon, 7 Mar 2022 09:05:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <5269403.vfdyTQepKt@thomas> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Thomas, v6 has been sent, thanks. ÔÚ 2022/3/7 6:52, Thomas Monjalon дµÀ: > 04/03/2022 16:35, Ferruh Yigit: >> On 3/4/2022 9:11 AM, Zhang, Yuying wrote: >>> From: Min Hu (Connor) >>>> From: Huisong Li >>>> >>>> This patch adds help messages for multi-process. >>>> --num-procs , where N is the total number of symmetric_mp instances >>>> that will be run side-by-side to perform packet processing. This parameter is >>>> used to configure the appropriate number of receive queues on each >>>> network port. >>>> >>>> --proc-id , where n is a numeric value in the range 0 <= n < N (number of >>>> processes, specified above). This identifies which symmetric_mp instance is >>>> being run, so that each process can read a unique receive queue on each >>>> network port. >>>> >>>> Fixes: a550baf24af9 ("app/testpmd: support multi-process") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Huisong Li >>>> Signed-off-by: Min Hu (Connor) >>> >>> Acked-by: Yuying Zhang >>> >> >> Updated 'symmetric_mp' -> 'multi-process', with this change >> Reviewed-by: Ferruh Yigit >> >> Applied to dpdk-next-net/main, thanks. > > Why not reusing these defines? > > #define PARAM_PROC_ID "proc-id" > #define PARAM_NUM_PROCS "num-procs" > > Why not having "N" in the help messages like others? > > I won't pull it in main. > Please rework and try to improve the description to make it shorter > and easier to understand. > > > . >