From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 963C45A1F for ; Tue, 20 Oct 2015 03:30:04 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 19 Oct 2015 18:30:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,705,1437462000"; d="scan'208";a="667669601" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 19 Oct 2015 18:30:02 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 19 Oct 2015 18:30:02 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.253]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.204]) with mapi id 14.03.0248.002; Tue, 20 Oct 2015 09:30:00 +0800 From: "Lu, Wenzhuo" To: "Van Haaren, Harry" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] ixgbe: fix 82599 / 82598 register differences Thread-Index: AQHQ/EKJ9TDLw/xb8EyjDx3XZ/acg55ztIaQ Date: Tue, 20 Oct 2015 01:29:59 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909020A09C7@shsmsx102.ccr.corp.intel.com> References: <1443701571-7000-1-git-send-email-harry.van.haaren@intel.com> In-Reply-To: <1443701571-7000-1-git-send-email-harry.van.haaren@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix 82599 / 82598 register differences X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 01:30:12 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren > Sent: Thursday, October 1, 2015 8:13 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] ixgbe: fix 82599 / 82598 register differences >=20 > Ixgbe based 82598 and 82599 have different priority recieve link-on regis= ter > addresses. This is solved in base/ by providing in the PXONRXC and > PXONXCNT as seperate macros. This patch ensures the correct address is > read, avoiding reading garbage values. >=20 > Also PXON2OFFCNT doesn't exist in 82598, so it is not read for that MAC. >=20 > This issue has existed since the drivers were imported into DPDK, but was > not easily discoverable as xstats were not available. > Tested using testpmd> show port xstats all >=20 > Fixes: af75078fece3 ("first public release") >=20 > Signed-off-by: Harry van Haaren Acked-by: Wenzhuo Lu