DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ixgbe: add mspdc to rx errors
@ 2015-10-27 10:22 Harry van Haaren
  2015-10-28  2:13 ` Lu, Wenzhuo
  0 siblings, 1 reply; 3+ messages in thread
From: Harry van Haaren @ 2015-10-27 10:22 UTC (permalink / raw)
  To: dev; +Cc: Harry van Haaren

This patch adds the mspdc (MAC Short Packet Discard Count)
to the total rx errors, as discussed on the dev@dpdk mailing
list: http://comments.gmane.org/gmane.comp.networking.dpdk.devel/23717

Suggested-by: Igor Ryzhov <iryzhov@arccn.ru>
Signed-off-by: Harry van Haaren <harry.van.haaren@gmail.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ec2918c..3221615 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2196,6 +2196,7 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 
 	/* Rx Errors */
 	stats->ierrors  = hw_stats->crcerrs +
+	                  hw_stats->mspdc +
 	                  hw_stats->rlec +
 	                  hw_stats->ruc +
 	                  hw_stats->roc +
-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: add mspdc to rx errors
  2015-10-27 10:22 [dpdk-dev] [PATCH] ixgbe: add mspdc to rx errors Harry van Haaren
@ 2015-10-28  2:13 ` Lu, Wenzhuo
  2015-10-28 14:15   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Lu, Wenzhuo @ 2015-10-28  2:13 UTC (permalink / raw)
  To: Van Haaren, Harry, dev; +Cc: Harry van Haaren

Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren
> Sent: Tuesday, October 27, 2015 6:22 PM
> To: dev@dpdk.org
> Cc: Harry van Haaren
> Subject: [dpdk-dev] [PATCH] ixgbe: add mspdc to rx errors
> 
> This patch adds the mspdc (MAC Short Packet Discard Count) to the total rx
> errors, as discussed on the dev@dpdk mailing
> list: http://comments.gmane.org/gmane.comp.networking.dpdk.devel/23717
> 
> Suggested-by: Igor Ryzhov <iryzhov@arccn.ru>
> Signed-off-by: Harry van Haaren <harry.van.haaren@gmail.com>
Yes, why not including it in the error counter :)
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: add mspdc to rx errors
  2015-10-28  2:13 ` Lu, Wenzhuo
@ 2015-10-28 14:15   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-10-28 14:15 UTC (permalink / raw)
  To: Van Haaren, Harry; +Cc: dev

> > This patch adds the mspdc (MAC Short Packet Discard Count) to the total rx
> > errors, as discussed on the dev@dpdk mailing
> > list: http://comments.gmane.org/gmane.comp.networking.dpdk.devel/23717
> > 
> > Suggested-by: Igor Ryzhov <iryzhov@arccn.ru>
> > Signed-off-by: Harry van Haaren <harry.van.haaren@gmail.com>
> Yes, why not including it in the error counter :)
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Thanks for thinking to add Suggested-by tag.
Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-10-28 14:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-27 10:22 [dpdk-dev] [PATCH] ixgbe: add mspdc to rx errors Harry van Haaren
2015-10-28  2:13 ` Lu, Wenzhuo
2015-10-28 14:15   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).