From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 7945B5A65
 for <dev@dpdk.org>; Wed, 28 Oct 2015 03:33:17 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga102.fm.intel.com with ESMTP; 27 Oct 2015 19:33:16 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,207,1444719600"; d="scan'208";a="821042286"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by fmsmga001.fm.intel.com with ESMTP; 27 Oct 2015 19:33:17 -0700
Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 27 Oct 2015 19:33:16 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 27 Oct 2015 19:33:16 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.253]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.96]) with mapi id 14.03.0248.002;
 Wed, 28 Oct 2015 10:33:14 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Mcnamara, John"
 <john.mcnamara@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v3 36/36] doc: update release notes for
 e1000 base code update
Thread-Index: AQHRB73E3yb0Ss7m8UiBlJ86eMBQB55/A60AgAE5yxA=
Date: Wed, 28 Oct 2015 02:33:13 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909020A3720@shsmsx102.ccr.corp.intel.com>
References: <1444804479-14840-1-git-send-email-wenzhuo.lu@intel.com>
 <1444963882-30931-1-git-send-email-wenzhuo.lu@intel.com>
 <1444963882-30931-37-git-send-email-wenzhuo.lu@intel.com>
 <2926566.0QgzZF02lo@xps13>
In-Reply-To: <2926566.0QgzZF02lo@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiIxN2Y5NzJjNS03OWU2LTQ4NWMtOGM2Yi0wYjljYTNkODE1MzIiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfUFVCTElDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaUJYamlac1JsSGhzbGVCeXhValdHSytLdGxGXC9OVTdKVnlmaTBcL3dhVUM4PSJ9
x-inteldataclassification: CTP_PUBLIC
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 36/36] doc: update release notes for e1000
 base code update
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Oct 2015 02:33:18 -0000

Hi John,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, October 27, 2015 11:32 PM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Mcnamara, John
> Subject: Re: [dpdk-dev] [PATCH v3 36/36] doc: update release notes for
> e1000 base code update
>=20
> 2015-10-16 10:51, Wenzhuo Lu:
> >  New Features
> >  ------------
> >
> > +* **Updated the e1000 base driver.**
> > +  The e1000 base driver was updated with several changes including the
> > +  following:
> > +
> > +  * Add some new i218 devices
> > +  * Fix issue with link flap on 82579
> > +  * Fix issue with jumbo frame CRC failures in client
> > +  * Add support for inverted format ETrackId
> > +  * Add flags to set eee advertisement modes
> > +  * Prevent ulp flow if cable connected
> > +  * Cleanup NAHUM6LP_HW tags
>=20
> Is it really a feature?
>=20
> > +  * Use the correct i210 register for EEMNGCTL
> > +  * Fix to enable both ulp and EEE in Sx state
> > +  * Fix link detect flow
> > +  * Set correct value of beacon duration
> > +  * Disable extension header parsing for IPv6
> > +  * Fix for i354 88E1112 PHY using AutoMedia Detect
> > +  * Implement 88E1543 PHY initialization
> > +  * Increase timeout of polling bit RSPCIPHY in check_reset_block
> > +  * Synchronization of MAC-PHY interface only on non- ME systems
>=20
> Some of theses features are not easy to understand.
> Please avoid to speak of the registers in the release notes.
> Something more high level is expected.
>=20
> > +  See the git log for full details of the e1000/base changes.
>=20
> This last sentence is valuable for any entry in the release notes.
> Let's say it is implicit.
>=20
> >  Resolved Issues
> >  ---------------
>=20
> Some of the fixes above should be in this section.
>=20
> John, please could you check?
>=20
> Thanks

Some fixes should be moved to Resolved Issues. But not sure if the "**Updat=
ed the e1000 base driver.**" still needed or describe them separately.
John, can you comment? Thanks.=20