From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0B51B2A5F for ; Tue, 2 Feb 2016 02:24:44 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 01 Feb 2016 17:24:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,382,1449561600"; d="scan'208";a="738727192" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 01 Feb 2016 17:24:43 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 1 Feb 2016 17:24:43 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 1 Feb 2016 17:24:43 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.172]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.231]) with mapi id 14.03.0248.002; Tue, 2 Feb 2016 09:24:40 +0800 From: "Lu, Wenzhuo" To: "Qiu, Michael" , Yuanhan Liu Thread-Topic: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwarding on Intel X550 NIC Thread-Index: AQHRWmNWWwijwDv6506hljYJ7HpcTJ8X+9Cg Date: Tue, 2 Feb 2016 01:24:40 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909034266EF@shsmsx102.ccr.corp.intel.com> References: <1454051035-25757-1-git-send-email-wenzhuo.lu@intel.com> <533710CFB86FA344BFBF2D6802E6028622F260A3@SHSMSX101.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09090342601B@shsmsx102.ccr.corp.intel.com> <20160201013948.GZ4257@yliu-dev.sh.intel.com> <533710CFB86FA344BFBF2D6802E6028622F281DE@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E6028622F281DE@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwarding on Intel X550 NIC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 01:24:45 -0000 Hi Michael, > -----Original Message----- > From: Qiu, Michael > Sent: Monday, February 1, 2016 4:32 PM > To: Yuanhan Liu; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwardi= ng on > Intel X550 NIC >=20 > On 2/1/2016 9:38 AM, Yuanhan Liu wrote: > > On Mon, Feb 01, 2016 at 01:04:52AM +0000, Lu, Wenzhuo wrote: > >> Hi, > >> > >>> -----Original Message----- > >>> From: Qiu, Michael > >>> Sent: Friday, January 29, 2016 3:16 PM > >>> To: Lu, Wenzhuo; dev@dpdk.org > >>> Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and > >>> forwarding on Intel X550 NIC > >>> > >>> Hi, Wenzhuo > >>> > >>> Better to explain what E-tag is, so that reviewers could known it. > >> Yes, it's better. But not sure where should I add this info. In releas= e note or > just cover letter? Any suggestion? Thanks. > > It should be done in the first patch introduced E-tag, so that it will > > be in the git log history. And of course, it does no harm at all to > > mention (briefly) it again in cover letter, so that > > reviewer/maintainer has a brief understanding of your whole patchset fi= rst. > > > > --yliu >=20 > Yes, in my view, cover letter is a good place, but as want to be in git l= og history, > it would be better to include in the right patch of the feature, because = most of > time, the first patch is not core related to new feature, perhaps only so= me > prepare code. >=20 >=20 > My opinion is to explain it where it first be mentioned in the code. I think it's good to explain it when we meet this concept at the first time= . I'll do that. Thanks. >=20 > But again, it OK for Yuanhan's solution, the only thing you want to do is= think > you are a reviewer, and want to review you patch, what do you want. >=20 > Thanks, > Michael