From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 873722BA5 for ; Fri, 26 Feb 2016 01:46:32 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 25 Feb 2016 16:46:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="924131057" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 25 Feb 2016 16:46:31 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Feb 2016 16:46:31 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Feb 2016 16:46:30 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.136]) with mapi id 14.03.0248.002; Fri, 26 Feb 2016 08:46:28 +0800 From: "Lu, Wenzhuo" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on x550em_x Thread-Index: AQHRXMyGF2pLEKBFe0SJnrlnYI5+jJ8a6L0AgB/2JQCAATsSAIAAR4eAgAFDDnA= Date: Fri, 26 Feb 2016 00:46:28 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909034358CC@shsmsx102.ccr.corp.intel.com> References: <1450684592-13564-1-git-send-email-wenzhuo.lu@intel.com> <1454316159-9528-1-git-send-email-wenzhuo.lu@intel.com> <20160224142606.GC19616@bricha3-MOBL3> <6A0DE07E22DDAD4C9103DF62FEBC09090343540D@shsmsx102.ccr.corp.intel.com> <20160225132946.GA20868@bricha3-MOBL3> In-Reply-To: <20160225132946.GA20868@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on x550em_x X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2016 00:46:33 -0000 Hi Bruce, > -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, February 25, 2016 9:30 PM > To: Lu, Wenzhuo > Cc: He, Shaopeng; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on x550em_x >=20 > On Thu, Feb 25, 2016 at 01:32:33AM +0000, Lu, Wenzhuo wrote: > > Hi Bruce, > > > > > -----Original Message----- > > > From: Richardson, Bruce > > > Sent: Wednesday, February 24, 2016 10:26 PM > > > To: He, Shaopeng > > > Cc: Lu, Wenzhuo; dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on > > > x550em_x > > > > > > On Thu, Feb 04, 2016 at 06:21:04AM +0000, He, Shaopeng wrote: > > > > > > > > > -----Original Message----- > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > > > > Sent: Monday, February 01, 2016 4:43 PM > > > > > To: dev@dpdk.org > > > > > Subject: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on > > > > > x550em_x > > > > > > > > > > Normally the auto-negotiation is supported by FW. But on > > > > > X550EM_X_10G_T it's not supported by FW. As the port of > > > > > X550EM_X_10G_T is 10G. If we connect the port with a peer which > > > > > is 1G. The link is always down. > > > > > We have to supprted auto-neg by SW to avoid such link down issue. > > > > > > > > > > Signed-off-by: Wenzhuo Lu > > > > Acked-by: Shaopeng He > > > > > > > I'm a bit confused regarding the commit message and the code in the p= atch. > > > The commit message talks about enabling speed auto-negotiation, > > > while the code never refers to any such thing. Instead all we have > > > are settings for manipulating interrupt masks to enable PHY > > > interrupts. I think some additional information is needed to connect = A and B > together here. > > The reason is that the handler of the link speed auto-neg is already in= the base > code. It's ixgbe_handle_lasi. > > What we need is a trigger. When the advertised link speed changes, a PH= Y > interruption will be triggered. So, we should handle this interruption an= d call > ixgbe_handle_lasi to set the link speed correct. > > Let me add more explanation in the commit log. > > > Yes, please do. What you have just explained makes much more sense and > should be included in the log. >=20 > > > > > > A second, more minor nit is that the commit title never refers to > > > link auto- negotiation, but refers to this as a bug fix - which is > > > also correct. If this is primarily a bug fix, please include a fixes > > > line if possible, but please also refer to auto-neg in the title if p= ossible too. > > I didn't add a fixes line because it doesn't fix an issue introduced by= SW, or > even FW, HW. As said in commit log, we hit a link down issue, but the roo= t cause > is the link speed auto-neg is not supported on this specific NIC. > > On the other NICs, link speed auto-neg is supported by FW, SW need no d= o > anything. So we didn't implement the link speed auto-neg. But we have to > implement this feature on this NIC for FW doesn't implement it. > > Should I change the tittle to "support link speed auto-neg on x550em_x"= ? > > >=20 > Yes, that is probably better. Thanks for the comments. I'll send a new version. >=20 > Thanks, > /Bruce