From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id EDFB02BD4 for ; Fri, 4 Mar 2016 02:16:54 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 03 Mar 2016 17:16:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,533,1449561600"; d="scan'208";a="59511403" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 03 Mar 2016 17:16:53 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 3 Mar 2016 17:16:53 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 3 Mar 2016 17:16:53 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.18]) with mapi id 14.03.0248.002; Fri, 4 Mar 2016 09:16:51 +0800 From: "Lu, Wenzhuo" To: "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] e1000: fix setting of VF MAC address Thread-Index: AQHRdJ33wrprsz4Hz0aOYidUIoEHs59HAEZwgAB7NxCAAQGKsA== Date: Fri, 4 Mar 2016 01:16:51 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090343789B@shsmsx102.ccr.corp.intel.com> References: <1456934946-15349-1-git-send-email-bernard.iremonger@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC090903437428@shsmsx102.ccr.corp.intel.com> <8CEF83825BEC744B83065625E567D7C219FB60B1@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C219FB60B1@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] e1000: fix setting of VF MAC address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 01:16:55 -0000 Hi, > > > Signed-off-by: Bernard Iremonger Acked-by: Wenzhuo Lu > > > --- > > > drivers/net/e1000/igb_ethdev.c | 12 +++++++++++- > > > drivers/net/e1000/igb_pf.c | 8 +++++--- > > > 2 files changed, 16 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/net/e1000/igb_ethdev.c > > > b/drivers/net/e1000/igb_ethdev.c index 4ed5e95..f1044b7 100644 > > > --- a/drivers/net/e1000/igb_ethdev.c > > > +++ b/drivers/net/e1000/igb_ethdev.c > > > @@ -1,7 +1,7 @@ > > > /*- > > > * BSD LICENSE > > > * > > > - * Copyright(c) 2010-2015 Intel Corporation. All rights reserved. > > > + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved. > > > * All rights reserved. > > > * > > > * Redistribution and use in source and binary forms, with or with= out > > > @@ -2819,6 +2819,7 @@ igbvf_dev_close(struct rte_eth_dev *dev) > > > struct e1000_hw *hw =3D E1000_DEV_PRIVATE_TO_HW(dev->data- > > > >dev_private); > > > struct e1000_adapter *adapter =3D > > > E1000_DEV_PRIVATE(dev->data->dev_private); > > > + struct ether_addr addr; > > > > > > PMD_INIT_FUNC_TRACE(); > > > > > > @@ -2827,6 +2828,15 @@ igbvf_dev_close(struct rte_eth_dev *dev) > > > igbvf_dev_stop(dev); > > > adapter->stopped =3D 1; > > > igb_dev_free_queues(dev); > > > + > > > + /** > > > + * reprogram the RAR with a zero mac address, > > > + * to ensure that the VF traffic goes to the PF > > > + * after stop, close and detach of the VF. > > > + **/ > > > + > > > + memset(&addr, 0, sizeof(addr)); > > > + igbvf_default_mac_addr_set(dev, &addr); > > > } > > > > > > static int igbvf_set_vfta(struct e1000_hw *hw, uint16_t vid, bool > > > on) diff --git a/drivers/net/e1000/igb_pf.c > > > b/drivers/net/e1000/igb_pf.c index > > > 1d00dda..95204e9 100644 > > > --- a/drivers/net/e1000/igb_pf.c > > > +++ b/drivers/net/e1000/igb_pf.c > > > @@ -1,7 +1,7 @@ > > > /*- > > > * BSD LICENSE > > > * > > > - * Copyright(c) 2010-2015 Intel Corporation. All rights reserved. > > > + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved. > > > * All rights reserved. > > > * > > > * Redistribution and use in source and binary forms, with or with= out > > > @@ -332,8 +332,10 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev, > > > uint32_t vf, uint32_t *msgbuf) > > > int rar_entry =3D hw->mac.rar_entry_count - (vf + 1); > > > uint8_t *new_mac =3D (uint8_t *)(&msgbuf[1]); > > > > > > - if (is_valid_assigned_ether_addr((struct ether_addr*)new_mac)) { > > > - rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); > > > + if (is_unicast_ether_addr((struct ether_addr *)new_mac)) { > > > + if (!is_zero_ether_addr((struct ether_addr *)new_mac)) > > > + rte_memcpy(vfinfo[vf].vf_mac_addresses, > > new_mac, > > > + sizeof(vfinfo[vf].vf_mac_addresses)); > > > hw->mac.ops.rar_set(hw, new_mac, rar_entry); > > If the new mac is 0, after this, the rar is 0, but the address stored > > in vfinfo is not changed and surely not 0. Right? > > So, they're not align with each other. Could it cause some problem? > > > > > return 0; > > > } > > > -- > > > 2.6.3 >=20 > vfinfo[vf].vf_mac_addresses contains the perm_addr MAC address. > I do not want to overwrite this with a zero address. If the VF is attache= d again it > uses the perm_addr MAC address. > The follow sequence works fine for me in testpmd, the VF is port 1: >=20 > Testpmd> port stop 1 > Testpmd> port close 1 /* VF MAC address is set to zero here */ > Testpmd> port detach 1 > Testpmd> port attach 0000:04:10.0 > Testpmd> show port info 1 /* VF MAC address is perm_addr MAC address > */ I think you're right. Only when the rar is 0, the vf_mac_addresses is diffe= rent from rar. So, we can use it to keep the permanent address. >=20 > Regards, >=20 > Bernard.