From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 551029A8A for ; Fri, 1 Apr 2016 02:39:16 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 31 Mar 2016 17:39:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,424,1455004800"; d="scan'208";a="935894058" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 31 Mar 2016 17:39:14 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 31 Mar 2016 17:39:14 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 31 Mar 2016 17:39:14 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.132]) with mapi id 14.03.0248.002; Fri, 1 Apr 2016 08:39:12 +0800 From: "Lu, Wenzhuo" To: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] igb: change default RX wthresh back Thread-Index: AQHRixVC3lJupsPeCEWOONe4RjIPfp9yofEAgAGk7tA= Date: Fri, 1 Apr 2016 00:39:12 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090903440D12@shsmsx102.ccr.corp.intel.com> References: <1459405129-12442-1-git-send-email-wenzhuo.lu@intel.com> <2601191342CEEE43887BDE71AB97725836B22B5F@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725836B22B5F@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] igb: change default RX wthresh back X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 00:39:16 -0000 Hi Konstantin, > -----Original Message----- > From: Ananyev, Konstantin > Sent: Thursday, March 31, 2016 3:30 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH] igb: change default RX wthresh back >=20 >=20 > Hi Wenzhuo, > > > > A problem is found on i350 VF. TX will happen once per 4 packets. If > > only 1~3 packets are received, they will not be forwarded. > > > > The reason is the default RX write-back threshold is changed to 4. > > This patch changes the value back to 0, so every packet can be handled > > immediately. > > > > Fixes: 4a41c17dba18 (igb: set default thresholds based on MAC type) > > Signed-off-by: Wenzhuo Lu > > --- > > drivers/net/e1000/igb_ethdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/e1000/igb_ethdev.c > > b/drivers/net/e1000/igb_ethdev.c index bd0ae26..34120ae 100644 > > --- a/drivers/net/e1000/igb_ethdev.c > > +++ b/drivers/net/e1000/igb_ethdev.c > > @@ -64,7 +64,7 @@ > > > > #define IGB_DEFAULT_RX_PTHRESH ((hw->mac.type =3D=3D e1000_i354) = ? 12 : > 8) > > #define IGB_DEFAULT_RX_HTHRESH 8 > > -#define IGB_DEFAULT_RX_WTHRESH ((hw->mac.type =3D=3D e1000_82576)= ? > 1 : 4) > > +#define IGB_DEFAULT_RX_WTHRESH 0 >=20 > But that still doesn't prevent user from setting wthresh to whatever he l= ikes > inside rx_queue_setup(), so the problem persists right? > As a side notice, it seems really bad practice to use implicit variables = inside > macro definition. > Konstantin Yes, you're right. It doesn't prevent the user from changing the value to t= rigger the problem. I'll withdraw this patch and create another one for this problem. Thanks. >=20 > > > > #define IGB_DEFAULT_TX_PTHRESH ((hw->mac.type =3D=3D e1000_i354) = ? 20 : > 8) > > #define IGB_DEFAULT_TX_HTHRESH 1 > > -- > > 1.9.3