From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 00C122C06 for ; Tue, 5 Apr 2016 02:57:19 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 04 Apr 2016 17:57:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,442,1455004800"; d="scan'208";a="680831077" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 04 Apr 2016 17:57:19 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 4 Apr 2016 17:57:18 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.24]) with mapi id 14.03.0248.002; Tue, 5 Apr 2016 08:57:16 +0800 From: "Lu, Wenzhuo" To: Stephen Hemminger , "Zhang, Helin" , "Ananyev, Konstantin" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting issues Thread-Index: AQHRjo0VhLgKEgiuv0qx3K9BPNUAWp96jiDA Date: Tue, 5 Apr 2016 00:57:16 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090344188F@shsmsx102.ccr.corp.intel.com> References: <1459786443-27501-1-git-send-email-stephen@networkplumber.org> In-Reply-To: <1459786443-27501-1-git-send-email-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2016 00:57:20 -0000 Hi Stephen, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, April 5, 2016 12:14 AM > To: Zhang, Helin; Ananyev, Konstantin > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting issu= es >=20 > This driver was one of the originals and has lots of little whitespace is= sues. >=20 > PS: I know Intel doesn't like whitespace changes, there is never a good t= ime > to do this, but no resuliting binary changes and it is unlikely that more > changes to this driver will occur this late in release cycle. >=20 > Signed-off-by: Stephen Hemminger Thanks for this patch. I think it's good to make the format better :) But there's some checkpatch error and warnings, like this, ERROR: "foo* bar" should be "foo *bar" #508: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4256: +ixgbe_uc_hash_table_set(struct rte_eth_dev *dev, struct ether_addr* mac_ad= dr,