From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BF61B2BCE for ; Tue, 12 Apr 2016 02:39:11 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 11 Apr 2016 17:39:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,471,1455004800"; d="scan'208";a="952933472" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 11 Apr 2016 17:39:09 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 11 Apr 2016 17:39:08 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.155]) with mapi id 14.03.0248.002; Tue, 12 Apr 2016 08:39:06 +0800 From: "Lu, Wenzhuo" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] lib: fix DCB config issue on ixgbe Thread-Index: AQHRk8uLeP4HaS0Cq0qXHG8M5XuRHZ+EAeiAgAF8ulA= Date: Tue, 12 Apr 2016 00:39:06 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090903454571@shsmsx102.ccr.corp.intel.com> References: <1460363050-27962-1-git-send-email-wenzhuo.lu@intel.com> <2081231.H599pWkcUZ@xps13> In-Reply-To: <2081231.H599pWkcUZ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lib: fix DCB config issue on ixgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2016 00:39:12 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, April 11, 2016 5:52 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib: fix DCB config issue on ixgbe >=20 > 2016-04-11 16:24, Wenzhuo Lu: > > An issue is found that DCB cannot be configged on ixgbe NICs. It's > > said the TX queue number is not right. > > On ixgbe the max TX queue number is not fixed, it depends on the > > multi-queue mode. The API rte_eth_dev_configure should be used to > > config this mode. But the input of this API includes TX queue number. > > The problem is before the mode is configged, we cannot decide the TX > > queue number. > > > > This patch adds an API to config RX & TX multi-queue mode separately. > > After the mode is configged, the max RX & TX queue number is decided. > > Then we can set the appropriate RX & TX queue number. > > > > Fixes: 96c0450dff86 (ixgbe: fix dropping packets from unsupported Tx > > queues) > > Signed-off-by: Wenzhuo Lu > > --- > > app/test-pmd/testpmd.c | 40 +++++++++++++++++++-------= -------- > > lib/librte_ether/rte_ethdev.c | 17 +++++++++++++++ > > lib/librte_ether/rte_ethdev.h | 19 ++++++++++++++++ > > lib/librte_ether/rte_ether_version.map | 1 + > > 4 files changed, 59 insertions(+), 18 deletions(-) >=20 > Obviously, it will be considered for 16.07. OK. I've got some feedback from the users that DCB is working, so I think i= t's not a critical issue and maybe only testpmd is impacted. I'll send a new version later. As rte_ether_version.map should be change fo= r 16.07. Thanks.