From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2D5B4C668 for ; Fri, 24 Jun 2016 02:43:45 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 23 Jun 2016 17:43:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,518,1459839600"; d="scan'208";a="982243386" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 23 Jun 2016 17:43:43 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 23 Jun 2016 17:43:43 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 23 Jun 2016 17:43:42 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.230]) with mapi id 14.03.0248.002; Fri, 24 Jun 2016 08:43:40 +0800 From: "Lu, Wenzhuo" To: Markos Chandras , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements Thread-Index: AQHRzTFccdXF/BzwqEurm4yxaP9Qe5/3x5bw Date: Fri, 24 Jun 2016 00:43:40 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090348A2A5@shsmsx102.ccr.corp.intel.com> References: <20160623092552.30932-1-mchandras@suse.de> In-Reply-To: <20160623092552.30932-1-mchandras@suse.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2016 00:43:45 -0000 Hi Markos, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Markos Chandras > Sent: Thursday, June 23, 2016 5:26 PM > To: dev@dpdk.org > Cc: Markos Chandras > Subject: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' > statements >=20 > Add the missing braces to the 'if' statements to fix the misleading ident= ation. > This also fixes the following build errors when building with gcc >=3D 6: >=20 > drivers/net/e1000/base/e1000_phy.c:4156:2: > error: this 'if' clause does not guard... [-Werror=3Dmisleading-indentati= on] if > (locked) ^~ >=20 > drivers/net/e1000/base/e1000_phy.c:4158:3: > note: ...this statement, but the latter is misleadingly indented as if it= is guarded > by the 'if' > if (!ready) > ^~ >=20 > drivers/net/e1000/base/e1000_phy.c: In function 'e1000_write_phy_reg_mphy= ': > drivers/net/e1000/base/e1000_phy.c:4221:2: > error: this 'if' clause does not guard... [-Werror=3Dmisleading-indentati= on] if > (locked) ^~ >=20 > drivers/net/e1000/base/e1000_phy.c:4223:3: > note: ...this statement, but the latter is misleadingly indented as if it= is guarded > by the 'if' > if (!ready) > ^~ >=20 > Signed-off-by: Markos Chandras Thanks for this patch. But normally the code in the base directory is synce= d from the kernel driver. So we don't change it if there's no critical issu= e. It's easy for us to maintain it. Thanks.