From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 68BB16CBD for ; Wed, 19 Oct 2016 02:47:18 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP; 18 Oct 2016 17:47:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,364,1473145200"; d="scan'208";a="21127866" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 18 Oct 2016 17:47:17 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 18 Oct 2016 17:47:16 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 18 Oct 2016 17:47:17 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.2]) with mapi id 14.03.0248.002; Wed, 19 Oct 2016 08:46:40 +0800 From: "Lu, Wenzhuo" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 3/3] app/testpmd: fix flow director endian issue Thread-Index: AQHSKLOoz3wM+GESm02jF3qrjAkhNqCu8tkQ Date: Wed, 19 Oct 2016 00:46:39 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093933CC76@shsmsx102.ccr.corp.intel.com> References: <1476085594-32325-1-git-send-email-wenzhuo.lu@intel.com> <1476253462-13000-1-git-send-email-wenzhuo.lu@intel.com> <1476253462-13000-4-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: fix flow director endian issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 00:47:18 -0000 Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Tuesday, October 18, 2016 4:19 AM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v2 3/3] app/testpmd: fix flow director end= ian > issue >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Tuesday, October 11, 2016 11:24 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo > > Subject: [dpdk-dev] [PATCH v2 3/3] app/testpmd: fix flow director > > endian issue > > > > The vlan mask and tunnel id mask of flow director are defined as big > > endian. So they should be converted. > > When the mask is printed, the parameters are not converted either. > > This patch converts the mask parameters. > > Some lines of the mask print are too long, split them to more lines. > > > > Fixes: 7c554b4f0484 ("app/testpmd: update display of flow director > > information") > > Fixes: 53b2bb9b7ea7 ("app/testpmd: new flow director commands") > > Signed-off-by: Wenzhuo Lu >=20 > Commit message should have a space between the Fixes and the Signed-off l= ine. > Apart from that: >=20 > Acked-by: Pablo de Lara Thanks for reviewing. I'll correct the commit log for all these patches.