From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 35C872BEB for ; Wed, 2 Nov 2016 01:38:17 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP; 01 Nov 2016 17:38:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,582,1473145200"; d="scan'208";a="26323193" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 01 Nov 2016 17:38:08 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 1 Nov 2016 17:38:07 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 1 Nov 2016 17:37:04 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.2]) with mapi id 14.03.0248.002; Wed, 2 Nov 2016 08:37:02 +0800 From: "Lu, Wenzhuo" To: Ananda Sathyanarayana Thread-Topic: [PATCH] E1000: fix for forced speed/duplex config Thread-Index: AQHSNJiqeYCcqsEPhEGcM3qWYmpg+6DE2NOQ Date: Wed, 2 Nov 2016 00:37:01 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909393404E2@shsmsx102.ccr.corp.intel.com> References: <1478040424-102624-1-git-send-email-ananda@versa-networks.com> In-Reply-To: <1478040424-102624-1-git-send-email-ananda@versa-networks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] E1000: fix for forced speed/duplex config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 00:38:18 -0000 Hi Ananda, > -----Original Message----- > From: Ananda Sathyanarayana [mailto:ananda@versa-networks.com] > Sent: Wednesday, November 2, 2016 6:47 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Ananda Sathyanarayana > Subject: [PATCH] E1000: fix for forced speed/duplex config >=20 > From the code, it looks like, hw->mac.autoneg, variable is used to switch > between calling either autoneg function or forcing speed/duplex function.= But > this variable is not modified in eth_em_start/eth_igb_start routines (it = is always > set to 1) even while forcing the link speed. >=20 > Following discussion thread has some more information on this >=20 > http://dpdk.org/ml/archives/dev/2016-October/049272.html >=20 > Signed-off-by: Ananda Sathyanarayana Thanks for the patch. It looks fine to me. But as it's a fix, would you lik= e to add a Fixes tag for it?