From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id DE3442A5D for ; Wed, 14 Dec 2016 01:45:01 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP; 13 Dec 2016 16:45:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,344,1477983600"; d="scan'208";a="39727125" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 13 Dec 2016 16:45:00 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 13 Dec 2016 16:45:00 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 13 Dec 2016 16:44:59 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.11]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.77]) with mapi id 14.03.0248.002; Wed, 14 Dec 2016 08:44:56 +0800 From: "Lu, Wenzhuo" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Chen, Jing D" , "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH 20/31] app/testpmd: use VFD APIs on i40e Thread-Index: AQHSTHUegW0ywPTEQk2eNCWqn1YXh6EFpO6AgAEIozA= Date: Wed, 14 Dec 2016 00:44:56 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B536586@SHSMSX103.ccr.corp.intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1480637533-37425-21-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 20/31] app/testpmd: use VFD APIs on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 00:45:02 -0000 Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, December 14, 2016 12:57 AM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Chen, Jing D; Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH 20/31] app/testpmd: use VFD APIs on i40e >=20 > On 12/2/2016 12:12 AM, Wenzhuo Lu wrote: > > The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd > > code to use them, inlcuding VF MAC anti-spoofing, VF VLAN > > anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert. > > > > Signed-off-by: Wenzhuo Lu > > Signed-off-by: Chen Jing D(Mark) > > Signed-off-by: Bernard Iremonger > > --- > > app/test-pmd/cmdline.c | 92 > > ++++++++++++++++++++++++++++++++++++++++++++++---- > > 1 file changed, 85 insertions(+), 7 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 63b55dc..1284d6c 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > <...> > > @@ -11059,8 +11109,20 @@ struct cmd_vf_vlan_insert_result { { > > struct cmd_vf_vlan_insert_result *res =3D parsed_result; > > int ret; > > + struct rte_eth_dev_info dev_info; > > + > > + memset(&dev_info, 0, sizeof(dev_info)); > > + rte_eth_dev_info_get(res->port_id, &dev_info); > > + > > + if (strstr(dev_info.driver_name, "ixgbe") !=3D NULL) > > + ret =3D rte_pmd_ixgbe_set_vf_vlan_insert(res->port_id, res->vf_id, > > + res->vlan_id); > > + else if (strstr(dev_info.driver_name, "i40e") !=3D NULL) > > + ret =3D rte_pmd_i40e_set_vf_vlan_insert(res->port_id, res->vf_id, > > + res->vlan_id); >=20 > This code is within "#ifdef RTE_LIBRTE_IXGBE_PMD", so i40e check can fail= if > IXGBE_PMD disabled, need to update surrounding ifdef. >=20 > Same for rest. Yes, will handle it. Thanks. >=20 > <...>