From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 86A6D2A6C for ; Fri, 6 Jan 2017 06:01:36 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 05 Jan 2017 21:01:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,323,1477983600"; d="scan'208";a="50698853" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 05 Jan 2017 21:01:34 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 5 Jan 2017 21:01:34 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 5 Jan 2017 21:01:34 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Fri, 6 Jan 2017 13:01:32 +0800 From: "Lu, Wenzhuo" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v7 06/27] net/i40e: set VF unicast promisc mode from PF Thread-Index: AQHSZ7RdtWRspj4BO0mAqArrYWn0oKEq5Dww Date: Fri, 6 Jan 2017 05:01:31 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5564A7@shsmsx102.ccr.corp.intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1483426488-117332-1-git-send-email-wenzhuo.lu@intel.com> <1483426488-117332-7-git-send-email-wenzhuo.lu@intel.com> <9BB6961774997848B5B42BEC655768F810CC3C8B@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810CC3C8B@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 06/27] net/i40e: set VF unicast promisc mode from PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2017 05:01:37 -0000 Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Friday, January 6, 2017 8:32 AM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v7 06/27] net/i40e: set VF unicast promisc > mode from PF >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Tuesday, January 3, 2017 2:54 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo > > Subject: [dpdk-dev] [PATCH v7 06/27] net/i40e: set VF unicast promisc > > mode from PF > > > > Support enabling/disabling VF unicast promiscuous mode from PF. > > User can call the API on PF to enable/disable a specific VF's unicast > > promiscuous mode. > > > > Signed-off-by: Wenzhuo Lu > > --- > > drivers/net/i40e/i40e_ethdev.c | 39 > > +++++++++++++++++++++++++++++++ > > drivers/net/i40e/rte_pmd_i40e.h | 19 +++++++++++++++ > > drivers/net/i40e/rte_pmd_i40e_version.map | 1 + > > 3 files changed, 59 insertions(+) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index a5d6d05..3d7ee03 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -10120,3 +10120,42 @@ static void i40e_set_default_mac_addr(struct > > rte_eth_dev *dev, > > > > return ret; > > } > > + > > +int > > +rte_pmd_i40e_set_vf_unicast_promisc(uint8_t port, uint16_t vf_id, > > +uint8_t on) { > > + struct rte_eth_dev *dev; > > + struct rte_eth_dev_info dev_info; > > + struct i40e_pf *pf; > > + struct i40e_vsi *vsi; > > + struct i40e_hw *hw; > > + int ret; > > + > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > > + > > + dev =3D &rte_eth_devices[port]; > > + rte_eth_dev_info_get(port, &dev_info); > > + > > + if (vf_id >=3D dev_info.max_vfs) > > + return -EINVAL; > > + > > + pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > > + > > + if (vf_id > pf->vf_num - 1 || !pf->vfs) { > > + PMD_DRV_LOG(ERR, "Invalid argument."); > > + return -EINVAL; > > + } > Same comments as previous patches. Thanks, will change it. >=20 > > + vsi =3D pf->vfs[vf_id].vsi; > > + if (!vsi) > > + return -EINVAL; > > + > > + hw =3D I40E_VSI_TO_HW(vsi); > > + > > + ret =3D i40e_aq_set_vsi_unicast_promiscuous(hw, vsi->seid, > > + on, NULL, true); > > + if (ret !=3D I40E_SUCCESS) > > + PMD_DRV_LOG(ERR, "Failed to set unicast promiscuous > mode"); > > + > > + return ret; > ret is the error code defined in i40e driver, please use the error code i= n eth dev > lib. Thanks. Will change it to the right error code. >=20 > Thanks > Jingjing