* [dpdk-dev] [PATCH] ixgbe: fix wrong VMDq function name
@ 2017-01-06 2:30 Wenzhuo Lu
2017-01-09 17:06 ` Iremonger, Bernard
2017-01-10 2:19 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
0 siblings, 2 replies; 6+ messages in thread
From: Wenzhuo Lu @ 2017-01-06 2:30 UTC (permalink / raw)
To: dev; +Cc: bernard.iremonger, Wenzhuo Lu, stable
The function name ixgbe_vmdq_mode_check is not right.
This function checks if Virtualization Technology is
enabled. It's for both VMDq and IOV.
Others may be misled by the current name.
Fixes: fe3a45fd4104 ("ixgbe: add VMDq support")
CC: stable@dpdk.org
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 060772d..e27a50d 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4417,14 +4417,14 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
}
static int
-ixgbe_vmdq_mode_check(struct ixgbe_hw *hw)
+ixgbe_vt_check(struct ixgbe_hw *hw)
{
uint32_t reg_val;
- /* we only need to do this if VMDq is enabled */
+ /* if Virtualization Technology is enabled */
reg_val = IXGBE_READ_REG(hw, IXGBE_VT_CTL);
if (!(reg_val & IXGBE_VT_CTL_VT_ENABLE)) {
- PMD_INIT_LOG(ERR, "VMDq must be enabled for this setting");
+ PMD_INIT_LOG(ERR, "VT must be enabled for this setting");
return -1;
}
@@ -4577,7 +4577,7 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
" on 82599 hardware and newer");
return -ENOTSUP;
}
- if (ixgbe_vmdq_mode_check(hw) < 0)
+ if (ixgbe_vt_check(hw) < 0)
return -ENOTSUP;
val = ixgbe_convert_vm_rx_mask_to_val(rx_mask, val);
@@ -4602,7 +4602,7 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
struct ixgbe_hw *hw =
IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
- if (ixgbe_vmdq_mode_check(hw) < 0)
+ if (ixgbe_vt_check(hw) < 0)
return -ENOTSUP;
if (pool >= ETH_64_POOLS)
@@ -4639,7 +4639,7 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
struct ixgbe_hw *hw =
IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
- if (ixgbe_vmdq_mode_check(hw) < 0)
+ if (ixgbe_vt_check(hw) < 0)
return -ENOTSUP;
if (pool >= ETH_64_POOLS)
@@ -4675,7 +4675,7 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
struct ixgbe_hw *hw =
IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
- if (ixgbe_vmdq_mode_check(hw) < 0)
+ if (ixgbe_vt_check(hw) < 0)
return -ENOTSUP;
for (pool_idx = 0; pool_idx < ETH_64_POOLS; pool_idx++) {
if (pool_mask & ((uint64_t)(1ULL << pool_idx))) {
@@ -4933,7 +4933,7 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
uint8_t mirror_type = 0;
- if (ixgbe_vmdq_mode_check(hw) < 0)
+ if (ixgbe_vt_check(hw) < 0)
return -ENOTSUP;
if (rule_id >= IXGBE_MAX_MIRROR_RULES)
@@ -5054,7 +5054,7 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
struct ixgbe_mirror_info *mr_info =
(IXGBE_DEV_PRIVATE_TO_PFDATA(dev->data->dev_private));
- if (ixgbe_vmdq_mode_check(hw) < 0)
+ if (ixgbe_vt_check(hw) < 0)
return -ENOTSUP;
memset(&mr_info->mr_conf[rule_id], 0,
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] ixgbe: fix wrong VMDq function name
2017-01-06 2:30 [dpdk-dev] [PATCH] ixgbe: fix wrong VMDq function name Wenzhuo Lu
@ 2017-01-09 17:06 ` Iremonger, Bernard
2017-01-09 17:37 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2017-01-10 2:19 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
1 sibling, 1 reply; 6+ messages in thread
From: Iremonger, Bernard @ 2017-01-09 17:06 UTC (permalink / raw)
To: Lu, Wenzhuo, dev; +Cc: stable
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Friday, January 6, 2017 2:31 AM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; stable@dpdk.org
> Subject: [PATCH] ixgbe: fix wrong VMDq function name
>
> The function name ixgbe_vmdq_mode_check is not right.
> This function checks if Virtualization Technology is enabled. It's for both
> VMDq and IOV.
> Others may be misled by the current name.
>
> Fixes: fe3a45fd4104 ("ixgbe: add VMDq support")
>
> CC: stable@dpdk.org
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] ixgbe: fix wrong VMDq function name
2017-01-09 17:06 ` Iremonger, Bernard
@ 2017-01-09 17:37 ` Ferruh Yigit
2017-01-10 1:02 ` Lu, Wenzhuo
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2017-01-09 17:37 UTC (permalink / raw)
To: Iremonger, Bernard, Lu, Wenzhuo, dev; +Cc: stable
On 1/9/2017 5:06 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Lu, Wenzhuo
>> Sent: Friday, January 6, 2017 2:31 AM
>> To: dev@dpdk.org
>> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; Lu, Wenzhuo
>> <wenzhuo.lu@intel.com>; stable@dpdk.org
>> Subject: [PATCH] ixgbe: fix wrong VMDq function name
>>
>> The function name ixgbe_vmdq_mode_check is not right.
>> This function checks if Virtualization Technology is enabled. It's for both
>> VMDq and IOV.
>> Others may be misled by the current name.
>>
>> Fixes: fe3a45fd4104 ("ixgbe: add VMDq support")
>>
>> CC: stable@dpdk.org
>> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>
Hi Wenzhuo,
This patch seems on top of main repo, would you mind sending a new
version rebased on next-net?
You can keep the Bernard's ack.
Thanks,
ferruh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] ixgbe: fix wrong VMDq function name
2017-01-09 17:37 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2017-01-10 1:02 ` Lu, Wenzhuo
0 siblings, 0 replies; 6+ messages in thread
From: Lu, Wenzhuo @ 2017-01-10 1:02 UTC (permalink / raw)
To: Yigit, Ferruh, Iremonger, Bernard, dev; +Cc: stable
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, January 10, 2017 1:37 AM
> To: Iremonger, Bernard; Lu, Wenzhuo; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] ixgbe: fix wrong VMDq function name
>
> On 1/9/2017 5:06 PM, Iremonger, Bernard wrote:
> >> -----Original Message-----
> >> From: Lu, Wenzhuo
> >> Sent: Friday, January 6, 2017 2:31 AM
> >> To: dev@dpdk.org
> >> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; Lu, Wenzhuo
> >> <wenzhuo.lu@intel.com>; stable@dpdk.org
> >> Subject: [PATCH] ixgbe: fix wrong VMDq function name
> >>
> >> The function name ixgbe_vmdq_mode_check is not right.
> >> This function checks if Virtualization Technology is enabled. It's
> >> for both VMDq and IOV.
> >> Others may be misled by the current name.
> >>
> >> Fixes: fe3a45fd4104 ("ixgbe: add VMDq support")
> >>
> >> CC: stable@dpdk.org
> >> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> >
> > Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
> >
>
> Hi Wenzhuo,
>
> This patch seems on top of main repo, would you mind sending a new version
> rebased on next-net?
Yes, it's based on the main repo. I'll send a V2 for next-net.
>
> You can keep the Bernard's ack.
>
> Thanks,
> ferruh
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] ixgbe: fix wrong VMDq function name
2017-01-06 2:30 [dpdk-dev] [PATCH] ixgbe: fix wrong VMDq function name Wenzhuo Lu
2017-01-09 17:06 ` Iremonger, Bernard
@ 2017-01-10 2:19 ` Wenzhuo Lu
2017-01-10 10:35 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Wenzhuo Lu @ 2017-01-10 2:19 UTC (permalink / raw)
To: dev; +Cc: Wenzhuo Lu, stable
The function name ixgbe_vmdq_mode_check is not right.
This function checks if Virtualization Technology is
enabled. It's for both VMDq and IOV.
Others may be misled by the current name.
Fixes: fe3a45fd4104 ("ixgbe: add VMDq support")
CC: stable@dpdk.org
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
v2:
- rebased the patch based on next-net.
drivers/net/ixgbe/ixgbe_ethdev.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 3bf9d32..b7ddd4f 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4405,14 +4405,14 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
}
static int
-ixgbe_vmdq_mode_check(struct ixgbe_hw *hw)
+ixgbe_vt_check(struct ixgbe_hw *hw)
{
uint32_t reg_val;
- /* we only need to do this if VMDq is enabled */
+ /* if Virtualization Technology is enabled */
reg_val = IXGBE_READ_REG(hw, IXGBE_VT_CTL);
if (!(reg_val & IXGBE_VT_CTL_VT_ENABLE)) {
- PMD_INIT_LOG(ERR, "VMDq must be enabled for this setting");
+ PMD_INIT_LOG(ERR, "VT must be enabled for this setting");
return -1;
}
@@ -4792,7 +4792,7 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
" on 82599 hardware and newer");
return -ENOTSUP;
}
- if (ixgbe_vmdq_mode_check(hw) < 0)
+ if (ixgbe_vt_check(hw) < 0)
return -ENOTSUP;
val = ixgbe_convert_vm_rx_mask_to_val(rx_mask, val);
@@ -4833,7 +4833,7 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
- if (ixgbe_vmdq_mode_check(hw) < 0)
+ if (ixgbe_vt_check(hw) < 0)
return -ENOTSUP;
/* for vf >= 32, set bit in PFVFRE[1], otherwise PFVFRE[0] */
@@ -4883,7 +4883,7 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
return -EINVAL;
hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
- if (ixgbe_vmdq_mode_check(hw) < 0)
+ if (ixgbe_vt_check(hw) < 0)
return -ENOTSUP;
/* for vf >= 32, set bit in PFVFTE[1], otherwise PFVFTE[0] */
@@ -4929,7 +4929,7 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
return -EINVAL;
hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
- if (ixgbe_vmdq_mode_check(hw) < 0)
+ if (ixgbe_vt_check(hw) < 0)
return -ENOTSUP;
for (vf_idx = 0; vf_idx < 64; vf_idx++) {
@@ -5060,7 +5060,7 @@ int rte_pmd_ixgbe_set_vf_rate_limit(uint8_t port, uint16_t vf,
IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
uint8_t mirror_type = 0;
- if (ixgbe_vmdq_mode_check(hw) < 0)
+ if (ixgbe_vt_check(hw) < 0)
return -ENOTSUP;
if (rule_id >= IXGBE_MAX_MIRROR_RULES)
@@ -5181,7 +5181,7 @@ int rte_pmd_ixgbe_set_vf_rate_limit(uint8_t port, uint16_t vf,
struct ixgbe_mirror_info *mr_info =
(IXGBE_DEV_PRIVATE_TO_PFDATA(dev->data->dev_private));
- if (ixgbe_vmdq_mode_check(hw) < 0)
+ if (ixgbe_vt_check(hw) < 0)
return -ENOTSUP;
memset(&mr_info->mr_conf[rule_id], 0,
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] ixgbe: fix wrong VMDq function name
2017-01-10 2:19 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
@ 2017-01-10 10:35 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2017-01-10 10:35 UTC (permalink / raw)
To: Wenzhuo Lu, dev; +Cc: stable
On 1/10/2017 2:19 AM, Wenzhuo Lu wrote:
> The function name ixgbe_vmdq_mode_check is not right.
> This function checks if Virtualization Technology is
> enabled. It's for both VMDq and IOV.
> Others may be misled by the current name.
>
> Fixes: fe3a45fd4104 ("ixgbe: add VMDq support")
>
> CC: stable@dpdk.org
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-10 10:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-06 2:30 [dpdk-dev] [PATCH] ixgbe: fix wrong VMDq function name Wenzhuo Lu
2017-01-09 17:06 ` Iremonger, Bernard
2017-01-09 17:37 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2017-01-10 1:02 ` Lu, Wenzhuo
2017-01-10 2:19 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
2017-01-10 10:35 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).