From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 48A4A282 for ; Wed, 11 Jan 2017 02:27:11 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 10 Jan 2017 17:27:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="921127948" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 10 Jan 2017 17:27:11 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 10 Jan 2017 17:27:10 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 10 Jan 2017 17:27:10 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Wed, 11 Jan 2017 09:27:08 +0800 From: "Lu, Wenzhuo" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Chen, Jing D" , "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH v8 18/25] app/testpmd: use VFD APIs on i40e Thread-Index: AQHSaxGEbETiF8aNZES8TthrSDmXMaExDVqAgACRCgCAANvyUA== Date: Wed, 11 Jan 2017 01:27:08 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B557CE2@shsmsx102.ccr.corp.intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1484032580-60134-1-git-send-email-wenzhuo.lu@intel.com> <1484032580-60134-19-git-send-email-wenzhuo.lu@intel.com> <8dfea289-72da-8a84-4d30-368d6d4ea4d6@intel.com> <598bd9db-073a-b40c-b60e-1d755b8f95ce@intel.com> In-Reply-To: <598bd9db-073a-b40c-b60e-1d755b8f95ce@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 18/25] app/testpmd: use VFD APIs on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 01:27:12 -0000 Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 4:09 AM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Chen, Jing D; Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH v8 18/25] app/testpmd: use VFD APIs on i40= e >=20 > On 1/10/2017 11:29 AM, Ferruh Yigit wrote: > > On 1/10/2017 7:16 AM, Wenzhuo Lu wrote: > >> The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd > >> code to use them, including VF MAC anti-spoofing, VF VLAN > >> anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert. > >> > >> Signed-off-by: Wenzhuo Lu > >> Signed-off-by: Chen Jing D(Mark) > >> Signed-off-by: Bernard Iremonger > >> --- > > > > <...> > > > >> +#ifdef RTE_LIBRTE_IXGBE_PMD > > > > Within this ifdef, there is following call: > > > > ret =3D rte_pmd_ixgbe_set_all_queues_drop_en(res->port_id, is_on); > > > > It is not safe to make that call directly, port should be verified > > first if it is ixgbe port, as done in other functions. >=20 > With a second thought, although this part is not correct, it is out of th= is > patches scope, because it concerns ixgbe related part. So below comment a= lso > become invalid. >=20 > Wenzhuo, >=20 > What do you think not changing this patch, but fixing this in a separate = patch? Agree. I'll not change this patch but fix this issue with a separate patch. >=20 > Thanks, > ferruh