From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Yi Zhang <zhang.yi75@zte.com.cn>,
"maintainer@some.org" <maintainer@some.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Dai, Wei" <wei.dai@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in ixgbevf
Date: Wed, 25 Jan 2017 01:21:42 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B55DC5F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20161214185019.19581-1-zhang.yi75@zte.com.cn>
Hi Yi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yi Zhang
> Sent: Thursday, December 15, 2016 2:50 AM
> To: maintainer@some.org
> Cc: dev@dpdk.org; Yi Zhang
> Subject: [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in ixgbevf
>
> Current ixgbevf driver get max_rx_pktlen = 15872, but in fact PF supports
> 15872-byte jumbo frame and VF only supports 9728-byte jumbo frame. If VF is
> running DPDK driver and set frame_size > 9728 ,PF running kernel ixgbe driver
> will report an error and set VF failed.
> This patch fixs DPDK ixgbevf driver to get correct jumbo frame size of VF.
>
> Signed-off-by: Yi Zhang <zhang.yi75@zte.com.cn>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index edc9b22..573252c 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3168,7 +3168,7 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
> dev_info->max_rx_queues = (uint16_t)hw->mac.max_rx_queues;
> dev_info->max_tx_queues = (uint16_t)hw->mac.max_tx_queues;
> dev_info->min_rx_bufsize = 1024; /* cf BSIZEPACKET in SRRCTL reg */
> - dev_info->max_rx_pktlen = 15872; /* includes CRC, cf MAXFRS reg */
> + dev_info->max_rx_pktlen = 9728; /* includes CRC, cf MAXFRS reg */
I don't see any hard limit for the VF. I checked the kernel code. It defines 9728 as max frame size, I believe for both PF and VF. It's SW limitation. That's why you see the error.
As kernel PF + dpdk VF is a common user case. I don't object to change the value to 9728. But I think some comments needed here to explain where this value comes from, because we can find the max frame size defined by dpdk, ETHER_MAX_JUMBO_FRAME_LEN, is different.
> dev_info->max_mac_addrs = hw->mac.num_rar_entries;
> dev_info->max_hash_mac_addrs = IXGBE_VMDQ_NUM_UC_MAC;
> dev_info->max_vfs = dev->pci_dev->max_vfs;
> --
> 2.9.3
>
prev parent reply other threads:[~2017-01-25 1:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 18:50 Yi Zhang
2016-12-14 7:06 ` Yuanhan Liu
2017-01-25 1:39 ` Dai, Wei
2017-01-25 1:42 ` Dai, Wei
2017-01-25 14:40 ` Ferruh Yigit
2017-01-25 1:21 ` Lu, Wenzhuo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B55DC5F@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=maintainer@some.org \
--cc=wei.dai@intel.com \
--cc=zhang.yi75@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).