From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 23558B6D for ; Wed, 25 Jan 2017 02:21:45 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 24 Jan 2017 17:21:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,281,1477983600"; d="scan'208";a="1117395311" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 24 Jan 2017 17:21:44 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 24 Jan 2017 17:21:44 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 24 Jan 2017 17:21:44 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Wed, 25 Jan 2017 09:21:42 +0800 From: "Lu, Wenzhuo" To: Yi Zhang , "maintainer@some.org" , "Ananyev, Konstantin" , "Dai, Wei" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in ixgbevf Thread-Index: AQHSVdRIHUkPK9B8SEKoUqZsPEF9IqFIpIJw Date: Wed, 25 Jan 2017 01:21:42 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B55DC5F@shsmsx102.ccr.corp.intel.com> References: <20161214185019.19581-1-zhang.yi75@zte.com.cn> In-Reply-To: <20161214185019.19581-1-zhang.yi75@zte.com.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2017 01:21:46 -0000 Hi Yi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yi Zhang > Sent: Thursday, December 15, 2016 2:50 AM > To: maintainer@some.org > Cc: dev@dpdk.org; Yi Zhang > Subject: [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in ixgbevf >=20 > Current ixgbevf driver get max_rx_pktlen =3D 15872, but in fact PF suppor= ts > 15872-byte jumbo frame and VF only supports 9728-byte jumbo frame. If VF = is > running DPDK driver and set frame_size > 9728 ,PF running kernel ixgbe dr= iver > will report an error and set VF failed. > This patch fixs DPDK ixgbevf driver to get correct jumbo frame size of VF= . >=20 > Signed-off-by: Yi Zhang > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index edc9b22..573252c 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3168,7 +3168,7 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev, > dev_info->max_rx_queues =3D (uint16_t)hw->mac.max_rx_queues; > dev_info->max_tx_queues =3D (uint16_t)hw->mac.max_tx_queues; > dev_info->min_rx_bufsize =3D 1024; /* cf BSIZEPACKET in SRRCTL reg */ > - dev_info->max_rx_pktlen =3D 15872; /* includes CRC, cf MAXFRS reg */ > + dev_info->max_rx_pktlen =3D 9728; /* includes CRC, cf MAXFRS reg */ I don't see any hard limit for the VF. I checked the kernel code. It define= s 9728 as max frame size, I believe for both PF and VF. It's SW limitation.= That's why you see the error. As kernel PF + dpdk VF is a common user case. I don't object to change the = value to 9728. But I think some comments needed here to explain where this = value comes from, because we can find the max frame size defined by dpdk, = ETHER_MAX_JUMBO_FRAME_LEN, is different. > dev_info->max_mac_addrs =3D hw->mac.num_rar_entries; > dev_info->max_hash_mac_addrs =3D IXGBE_VMDQ_NUM_UC_MAC; > dev_info->max_vfs =3D dev->pci_dev->max_vfs; > -- > 2.9.3 >=20