From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id DF8EC2C56 for ; Tue, 28 Feb 2017 06:04:39 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 27 Feb 2017 21:04:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,217,1484035200"; d="scan'208";a="69819383" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 27 Feb 2017 21:04:38 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 27 Feb 2017 21:04:38 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Tue, 28 Feb 2017 13:04:36 +0800 From: "Lu, Wenzhuo" To: Vincent JARDIN , Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel divergence Thread-Index: AQHSjn5scdRBvqG+JEazbrh6sAY41qF94pXA Date: Tue, 28 Feb 2017 05:04:35 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5694B6@shsmsx102.ccr.corp.intel.com> References: <1487906675-54260-1-git-send-email-wenzhuo.lu@intel.com> <20170223225507.69ee0e47@xeon-e3> <6A0DE07E22DDAD4C9103DF62FEBC09093B5682B7@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel divergence X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 05:04:40 -0000 Hi Vincent, > -----Original Message----- > From: Vincent JARDIN [mailto:vincent.jardin@6wind.com] > Sent: Friday, February 24, 2017 5:14 PM > To: Lu, Wenzhuo; Stephen Hemminger > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel > divergence >=20 > Le 24/02/2017 =E0 08:23, Lu, Wenzhuo a =E9crit : > >> It is good to allow setting QoS on device, but it looks like this is > >> a device specific API, not a generic PMD function. I don't think any > >> feature in DPDK should be hardcoded to one device type. > > Yes, they're private APIs. > > Normally we want to support kernel PF + dpdk VF. As there's no PF - VF > interface defined for QoS, These features cannot be implemented on VF now= . > > Have to put them on PF, and let PF play as a controller. > > There's discussion about if we should rich PF host features. So, I put = these > functions to rte_pmd_i40e.h to show they're experimental and temporary > features. > > > > There's another thread started by Cristian for a generic QoS solution. = After it's > accepted and the PF-VF interfaces are defined by kernel driver. We can us= e a > generic solution to replace this one. >=20 > Same, DPDK continues to diverge from the Linux kernel for PF capabilities= . Intel > did commit previously that you'll do some works for proper PF support int= o the > kernel to avoid it. It is not happening. So, I would rather keep nack'ing= such > series unless: > - either it is under experimental compilation option Yes, they're experimental. I put the functions in the rte_pmd_i40e.h. All t= he functions in this file are announced experimental. > - either it is showing up into the kernel We're discussing this internally in parallel. >=20 > Best regards, > Vincent