From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7DD312A5E for ; Fri, 3 Mar 2017 02:35:23 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2017 17:35:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,234,1484035200"; d="scan'208";a="231712728" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 02 Mar 2017 17:35:22 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 2 Mar 2017 17:35:22 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Fri, 3 Mar 2017 09:35:20 +0800 From: "Lu, Wenzhuo" To: "Kozak, KubaX" , "dev@dpdk.org" CC: "Piasecki, JacekX" , "Kozak, KubaX" Thread-Topic: [dpdk-dev] [PATCH 2/4] net/e1000: add grouping of xstats for e1000 driver Thread-Index: AQHSk2F/VSB0LodZCkSojiPQeUyNEaGCVXDQ Date: Fri, 3 Mar 2017 01:35:19 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B56A6A8@shsmsx102.ccr.corp.intel.com> References: <1488470875-26716-1-git-send-email-kubax.kozak@intel.com> <1488470875-26716-3-git-send-email-kubax.kozak@intel.com> In-Reply-To: <1488470875-26716-3-git-send-email-kubax.kozak@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/4] net/e1000: add grouping of xstats for e1000 driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 01:35:23 -0000 Hi Kuba, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kuba Kozak > Sent: Friday, March 3, 2017 12:08 AM > To: dev@dpdk.org > Cc: Piasecki, JacekX; Kozak, KubaX > Subject: [dpdk-dev] [PATCH 2/4] net/e1000: add grouping of xstats for e10= 00 > driver >=20 > From: Jacek Piasecki >=20 > This patch extends the 'rte_igb_xstats_name_off' structure with additiona= l field > 'group_mask'. For each xstats there is now specified group (e.g. TX_GROUP= ), > one xstatistic can be in several groups. > To implement new functionality of retriving xstats by group on driver lev= el, there > are two functions added: > eth_igb_xstats_get_by_group() and eth_igb_xstats_get_names_by_group() >=20 > Signed-off-by: Jacek Piasecki > Signed-off-by: Kuba Kozak =20 > #define IGBVF_NB_XSTATS (sizeof(rte_igbvf_stats_strings) / \ @@ -1771,6 > +1832,13 @@ struct rte_igb_xstats_name_off { > stats->cexterr +=3D E1000_READ_REG(hw, E1000_CEXTERR); > stats->tsctc +=3D E1000_READ_REG(hw, E1000_TSCTC); > stats->tsctfc +=3D E1000_READ_REG(hw, E1000_TSCTFC); > + > + if (hw->mac.type =3D=3D e1000_i350 || hw->mac.type =3D=3D e1000_i210) { > + stats->o2bgptc +=3D E1000_READ_REG(hw, E1000_O2BGPTC); > + stats->o2bspc +=3D E1000_READ_REG(hw, E1000_O2BSPC); > + stats->b2ospc +=3D E1000_READ_REG(hw, E1000_B2OSPC); > + stats->b2ogprc +=3D E1000_READ_REG(hw, E1000_B2OGPRC); > + } Seems this code doesn't belong to this topic. Could it be split to an isola= te patch? BTW, I can only find 3 patches in this patch set. 4/4 is missing.