From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id ACAAA2C37 for ; Sat, 1 Apr 2017 09:28:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491031711; x=1522567711; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3JDmG2HymgtKtitEOoanEWqlHX9peWj/iG53KTrPSm8=; b=whsG6nzAOJr89iwLEZyrZv1K5RUKKIZlUG7yp5uwmcxiBRZqVLtPeUKW SmPQzLhxXM1jGlyCw5XJTzigwxiLig==; Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2017 00:28:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,256,1486454400"; d="scan'208";a="1149589252" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 01 Apr 2017 00:28:05 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 1 Apr 2017 00:28:05 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 1 Apr 2017 00:28:05 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.212]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.253]) with mapi id 14.03.0248.002; Sat, 1 Apr 2017 15:28:03 +0800 From: "Lu, Wenzhuo" To: "Zhang, Helin" , Thomas Monjalon , Yongseok Koh , "Yigit, Ferruh" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "adrien.mazarguil@6wind.com" , "nelio.laranjeiro@6wind.com" Thread-Topic: [PATCH v2 1/3] lib/librte_ether: remove requirement of aligned RETA size Thread-Index: AQHSqfE2WwoTWjp8fEOSRcVCH6Pe66GwHrLQ Date: Sat, 1 Apr 2017 07:28:02 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B58649D@shsmsx102.ccr.corp.intel.com> References: <20170316224056.19685-1-yskoh@mellanox.com> <7783e46e840052a9abdd4e8962eede598ab848af.1490050764.git.yskoh@mellanox.com> <1920337.9E3jvcbJyk@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ether: remove requirement of aligned RETA size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Apr 2017 07:28:32 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Helin > Sent: Friday, March 31, 2017 3:34 PM > To: Thomas Monjalon; Yongseok Koh; Yigit, Ferruh; Ananyev, Konstantin > Cc: dev@dpdk.org; adrien.mazarguil@6wind.com; > nelio.laranjeiro@6wind.com > Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ether: remove requireme= nt > of aligned RETA size >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Thursday, March 30, 2017 8:38 AM > > To: Yongseok Koh; Yigit, Ferruh; Zhang, Helin; Ananyev, Konstantin > > Cc: dev@dpdk.org; adrien.mazarguil@6wind.com; > > nelio.laranjeiro@6wind.com > > Subject: Re: [PATCH v2 1/3] lib/librte_ether: remove requirement of > > aligned RETA size > > > > 2017-03-20 16:04, Yongseok Koh: > > > In rte_eth_check_reta_mask(), it is required to align the size of > > > the RETA table to RTE_RETA_GROUP_SIZE but as the size can be less > > > than the limit, this should be removed. The change is also applied > > > to a command of > > testpmd. > > > > > > Signed-off-by: Yongseok Koh > > [...] > > > - if (reta_size !=3D RTE_ALIGN(reta_size, RTE_RETA_GROUP_SIZE)) { > > > - RTE_PMD_DEBUG_TRACE("Invalid reta size, should be %u > > aligned\n", > > > - > > RTE_RETA_GROUP_SIZE); > > > - return -EINVAL; > > > - } > > > - > > > - num =3D reta_size / RTE_RETA_GROUP_SIZE; > > > + num =3D (reta_size + RTE_RETA_GROUP_SIZE - 1) / > > RTE_RETA_GROUP_SIZE; > > > > There is no comment for this constraint neither in the code nor in the > > commit: http://dpdk.org/commit/66c594904 So, I guess it can be removed. > > If a check is needed, it could be added in the relevant drivers. > > > > Helin, Konstantin, please check for Intel drivers. > Hi Thomas >=20 > Thank you very much for the reminder! > We will check that and see if there is any impacts to Intel drivers. I don't think it has any impact to the drivers. To my opinion, it's a good fix as it makes the name ' reta_size' more reaso= nable. >=20 > Regards, > Helin > > > > Ferruh, please take care of this series.