From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 840EF2A62 for ; Tue, 2 May 2017 10:14:04 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 02 May 2017 01:14:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,404,1488873600"; d="scan'208";a="851930033" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 02 May 2017 01:14:02 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 2 May 2017 01:14:02 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 2 May 2017 01:14:02 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Tue, 2 May 2017 16:14:00 +0800 From: "Lu, Wenzhuo" To: "Zhao1, Wei" , "dev@dpdk.org" Thread-Topic: [PATCH] net/e1000: fix checksum valid flags error Thread-Index: AQHSwu+HlXlp+P98Vk+0i93sdit78KHgsbQQ Date: Tue, 2 May 2017 08:13:59 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B59EA99@shsmsx102.ccr.corp.intel.com> References: <1493693163-22862-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1493693163-22862-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix checksum valid flags error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2017 08:14:05 -0000 Hi Wei, > -----Original Message----- > From: Zhao1, Wei > Sent: Tuesday, May 2, 2017 10:46 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; Zhao1, Wei > Subject: [PATCH] net/e1000: fix checksum valid flags error >=20 > This problem is caused by a missing set of E1000_RXCSUM_CRCOFL in > eth_igb_rx_init(), it should be set to enable SCTP packet > L4 checksum.If it is not set, the printf message in cksum fwd about L4 SC= TP > cksum flag is error. It's not quite clear what's the issue. Would you like to add more details? = Thanks. >=20 > Fixes: d15fcf76c8b7 ("net/e1000: move to drivers/net/") Seems it's not the right patch. Suppose this patch only moves the files. >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/e1000/igb_rxtx.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c = index > b3b601b..6c2749b 100644 > --- a/drivers/net/e1000/igb_rxtx.c > +++ b/drivers/net/e1000/igb_rxtx.c > @@ -2402,10 +2402,11 @@ eth_igb_rx_init(struct rte_eth_dev *dev) >=20 > /* Enable both L3/L4 rx checksum offload */ > if (dev->data->dev_conf.rxmode.hw_ip_checksum) > - rxcsum |=3D (E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL); > + rxcsum |=3D (E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL | > + E1000_RXCSUM_CRCOFL); > else > - rxcsum &=3D ~(E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL); > - E1000_WRITE_REG(hw, E1000_RXCSUM, rxcsum); > + rxcsum &=3D ~(E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL > | > + E1000_RXCSUM_CRCOFL); >=20 > /* Setup the Receive Control Register. */ > if (dev->data->dev_conf.rxmode.hw_strip_crc) { > -- > 2.9.3