From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 8593D5689 for ; Thu, 1 Jun 2017 09:05:42 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jun 2017 00:05:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,278,1493708400"; d="scan'208";a="94237205" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 01 Jun 2017 00:05:37 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Jun 2017 00:05:36 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Jun 2017 00:05:36 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Thu, 1 Jun 2017 15:05:34 +0800 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "Zhang, Helin" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 1/3] net/ixgbe: remove reduandent code Thread-Index: AQHS2oIZjg8B6yAmrUa8G6soww44oKIPlZQg Date: Thu, 1 Jun 2017 07:05:34 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5C9AE5@shsmsx102.ccr.corp.intel.com> References: <1496259940-15547-1-git-send-email-qi.z.zhang@intel.com> <1496259940-15547-2-git-send-email-qi.z.zhang@intel.com> In-Reply-To: <1496259940-15547-2-git-send-email-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/ixgbe: remove reduandent code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 07:05:44 -0000 Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, June 1, 2017 3:46 AM > To: Lu, Wenzhuo; Zhang, Helin > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2 1/3] net/ixgbe: remove reduandent code >=20 > Remove reduandent code. > item->type !=3D RTE_FLOW_ITEM_TYPE_END already cover type =3D=3D > item->RTE_FLOW_ITEM_TYPE_VLAN. >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/ixgbe/ixgbe_flow.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flo= w.c > index da7b1cc..2c09444 100644 > --- a/drivers/net/ixgbe/ixgbe_flow.c > +++ b/drivers/net/ixgbe/ixgbe_flow.c > @@ -1549,13 +1549,7 @@ ixgbe_parse_fdir_filter_normal(const struct > rte_flow_attr *attr, > */ Please change the above comments too. > index++; > NEXT_ITEM_OF_PATTERN(item, pattern, index); > - if (item->type =3D=3D RTE_FLOW_ITEM_TYPE_VLAN) { > - memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); > - rte_flow_error_set(error, EINVAL, > - RTE_FLOW_ERROR_TYPE_ITEM, > - item, "Not supported by fdir filter"); > - return -rte_errno; > - } else if (item->type !=3D RTE_FLOW_ITEM_TYPE_END) { > + if (item->type !=3D RTE_FLOW_ITEM_TYPE_END) { > memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ITEM, > -- > 2.7.4