From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 78DBF7CE5 for ; Fri, 2 Jun 2017 04:14:30 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jun 2017 19:14:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,282,1493708400"; d="scan'208";a="1177285268" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 01 Jun 2017 19:14:28 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Jun 2017 19:14:28 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Jun 2017 19:14:28 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Fri, 2 Jun 2017 10:14:26 +0800 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "Zhang, Helin" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow API Thread-Index: AQHS2oIc2AErxqEcAkCf6cU20aYLEaIPsjqAgACal4CAAIkA4A== Date: Fri, 2 Jun 2017 02:14:26 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5CB000@shsmsx102.ccr.corp.intel.com> References: <1496259940-15547-1-git-send-email-qi.z.zhang@intel.com> <1496259940-15547-4-git-send-email-qi.z.zhang@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B5CAFB2@shsmsx102.ccr.corp.intel.com> <039ED4275CED7440929022BC67E70611530A71E0@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611530A71E0@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2017 02:14:31 -0000 Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, June 2, 2017 10:00 AM > To: Lu, Wenzhuo; Zhang, Helin > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow= API >=20 >=20 >=20 > > -----Original Message----- > > From: Lu, Wenzhuo > > Sent: Friday, June 2, 2017 9:49 AM > > To: Zhang, Qi Z ; Zhang, Helin > > > > Cc: dev@dpdk.org > > Subject: RE: [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic > > flow API > > > > Hi Qi, > > > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Thursday, June 1, 2017 3:46 AM > > > To: Lu, Wenzhuo; Zhang, Helin > > > Cc: dev@dpdk.org; Zhang, Qi Z > > > Subject: [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic > > > flow API > > > > > > Add fdir flex byte support for rte_flow APIs. > > > > > > Signed-off-by: Qi Zhang > > > --- > > > > > > v2: > > > - fix couple checkpatch errors. > > > > > > drivers/net/ixgbe/ixgbe_ethdev.h | 3 + > > > drivers/net/ixgbe/ixgbe_fdir.c | 31 ++++++++- > > > drivers/net/ixgbe/ixgbe_flow.c | 137 > > > ++++++++++++++++++++++++++++++++++++++- > > > 3 files changed, 167 insertions(+), 4 deletions(-) > > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_fdir.c > > > b/drivers/net/ixgbe/ixgbe_fdir.c index 7f6c7b5..950f5ba 100644 > > > --- a/drivers/net/ixgbe/ixgbe_fdir.c > > > +++ b/drivers/net/ixgbe/ixgbe_fdir.c > > > @@ -302,7 +302,7 @@ fdir_set_input_mask_82599(struct rte_eth_dev > > *dev) > > > * mask VM pool and DIPv6 since there are currently not supported > > > * mask FLEX byte, it will be set in flex_conf > > > */ > > > - uint32_t fdirm =3D IXGBE_FDIRM_POOL | IXGBE_FDIRM_DIPv6 | > > > IXGBE_FDIRM_FLEX; > > > + uint32_t fdirm =3D IXGBE_FDIRM_POOL | IXGBE_FDIRM_DIPv6; > > > uint32_t fdirtcpm; /* TCP source and destination port masks. */ > > > uint32_t fdiripv6m; /* IPv6 source and destination masks. */ > > > volatile uint32_t *reg; > > > @@ -333,6 +333,10 @@ fdir_set_input_mask_82599(struct rte_eth_dev > > *dev) > > > return -EINVAL; > > > } > > > > > > + /* flex byte mask */ > > > + if (info->mask.flex_bytes_mask =3D=3D 0) > > > + fdirm |=3D IXGBE_FDIRM_FLEX; > > > + > > > IXGBE_WRITE_REG(hw, IXGBE_FDIRM, fdirm); > > Should the same change be done for x550? > > > Currently I didn't see it is necessary. > Because I saw fdir_set_input_mask_x550 will only be used for mac-vlan and > tunneling filter where flex byte is not considered in this patch. so keep= it > disabled Please correct if I miss something. O, this patch only enables flexible bytes for IP flow. You already say that= in the comments. It's not necessary to change the x550 code. Acked-by: Wenzhuo Lu