From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 90DB67CDF for ; Mon, 5 Jun 2017 03:21:22 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2017 18:21:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,298,1493708400"; d="scan'208";a="1156524683" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 04 Jun 2017 18:21:20 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 4 Jun 2017 18:21:20 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 4 Jun 2017 18:21:20 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Mon, 5 Jun 2017 09:21:18 +0800 From: "Lu, Wenzhuo" To: "Zhao1, Wei" , "dev@dpdk.org" Thread-Topic: [PATCH v2 05/11] net/e1000: parse n-tuple filter Thread-Index: AQHS22vdL9Wr5bw1Sk2LeyZtVoPopqIVfGHw Date: Mon, 5 Jun 2017 01:21:17 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5CBA66@shsmsx102.ccr.corp.intel.com> References: <1495523581-56027-1-git-send-email-wei.zhao1@intel.com> <1496385391-12445-1-git-send-email-wei.zhao1@intel.com> <1496385391-12445-6-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1496385391-12445-6-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 05/11] net/e1000: parse n-tuple filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jun 2017 01:21:23 -0000 Hi Wei, > -----Original Message----- > From: Zhao1, Wei > Sent: Friday, June 2, 2017 2:36 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; Zhao1, Wei > Subject: [PATCH v2 05/11] net/e1000: parse n-tuple filter >=20 > Add rule validate function and check if the rule is a n-tuple rule, and g= et the > n-tuple info. >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/e1000/Makefile | 1 + > drivers/net/e1000/e1000_ethdev.h | 9 + > drivers/net/e1000/igb_ethdev.c | 14 +- > drivers/net/e1000/igb_flow.c | 505 > +++++++++++++++++++++++++++++++++++++++ > 4 files changed, 521 insertions(+), 8 deletions(-) create mode 100644 > + > + if (hw->mac.type =3D=3D e1000_82576) { > + if (filter->queue >=3D IGB_MAX_RX_QUEUE_NUM_82576) { > + memset(filter, 0, sizeof(struct rte_eth_ntuple_filter)); > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM, > + NULL, "queue number not " > + "supported by ntuple filter"); > + return -rte_errno; > + } > + filter->flags |=3D RTE_5TUPLE_FLAGS; To my opinion, that the filter is 5-tuple or 2-tuple should depend on the i= nput pattern. I don't understand why it's set based on the NIC type. > + } else { > + if (filter->queue >=3D IGB_MAX_RX_QUEUE_NUM) { > + memset(filter, 0, sizeof(struct rte_eth_ntuple_filter)); > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM, > + NULL, "queue number not " > + "supported by ntuple filter"); > + return -rte_errno; > + } > + filter->flags |=3D RTE_2TUPLE_FLAGS; > + }