From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id DB1F97CDF
 for <dev@dpdk.org>; Mon,  5 Jun 2017 05:14:09 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 04 Jun 2017 20:14:08 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,299,1493708400"; d="scan'208";a="1137967314"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by orsmga001.jf.intel.com with ESMTP; 04 Jun 2017 20:14:05 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Sun, 4 Jun 2017 20:13:58 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002;
 Mon, 5 Jun 2017 11:13:56 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2 06/11] net/e1000: parse ethertype filter
Thread-Index: AQHS22vdd2nUOkcm4kqlL6+Gqr2pzqIVnDDg
Date: Mon, 5 Jun 2017 03:13:55 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5CBAFB@shsmsx102.ccr.corp.intel.com>
References: <1495523581-56027-1-git-send-email-wei.zhao1@intel.com>
 <1496385391-12445-1-git-send-email-wei.zhao1@intel.com>
 <1496385391-12445-7-git-send-email-wei.zhao1@intel.com>
In-Reply-To: <1496385391-12445-7-git-send-email-wei.zhao1@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 06/11] net/e1000: parse ethertype filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jun 2017 03:14:10 -0000

Hi Wei,


> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, June 2, 2017 2:36 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo; Zhao1, Wei
> Subject: [PATCH v2 06/11] net/e1000: parse ethertype filter
>=20
> check if the rule is a ethertype rule, and get the ethertype info.
>=20
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  drivers/net/e1000/igb_flow.c | 280
> +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 280 insertions(+)

> +
> +	/* The first non-void item should be MAC. */
> +	item =3D pattern + index;
> +	while (item->type =3D=3D RTE_FLOW_ITEM_TYPE_VOID) {
> +		index++;
> +		item =3D pattern + index;
> +	}
You've created a macro to do it in the previous patch, why not use the macr=
o? The same below.