From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 297317CDF for ; Mon, 5 Jun 2017 05:38:56 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 04 Jun 2017 20:38:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,299,1493708400"; d="scan'208";a="976761186" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 04 Jun 2017 20:38:55 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 4 Jun 2017 20:38:54 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 4 Jun 2017 20:38:54 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Mon, 5 Jun 2017 11:38:53 +0800 From: "Lu, Wenzhuo" To: "Zhao1, Wei" , "dev@dpdk.org" Thread-Topic: [PATCH v2 08/11] net/e1000: parse flex filter Thread-Index: AQHS22vdoVOi+TuFXEGw26legNp1EKIVo03w Date: Mon, 5 Jun 2017 03:38:52 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5CBB30@shsmsx102.ccr.corp.intel.com> References: <1495523581-56027-1-git-send-email-wei.zhao1@intel.com> <1496385391-12445-1-git-send-email-wei.zhao1@intel.com> <1496385391-12445-9-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1496385391-12445-9-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 08/11] net/e1000: parse flex filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jun 2017 03:38:57 -0000 Hi Wei, > -----Original Message----- > From: Zhao1, Wei > Sent: Friday, June 2, 2017 2:36 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; Zhao1, Wei > Subject: [PATCH v2 08/11] net/e1000: parse flex filter >=20 > check if the rule is a flex byte rule, and get the flex info. >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/e1000/e1000_ethdev.h | 6 + > drivers/net/e1000/igb_ethdev.c | 6 - > drivers/net/e1000/igb_flow.c | 276 > +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 282 insertions(+), 6 deletions(-) > + > + /* check if the next not void item is END */ > + if (item->type !=3D RTE_FLOW_ITEM_TYPE_END) { > + memset(filter, 0, sizeof(struct rte_eth_flex_filter)); > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM, > + item, "Not supported by flex filter"); > + return -rte_errno; > + } Seems this check is not necessary. I think the item must be END here. > + > + /* parse action */ > + index =3D 0; > + > + /* check if the first not void action is QUEUE. */ > + NEXT_ITEM_OF_ACTION(act, actions, index); > + if (act->type !=3D RTE_FLOW_ACTION_TYPE_QUEUE) { > + memset(filter, 0, sizeof(struct rte_eth_flex_filter)); > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION, > + act, "Not supported action."); > + return -rte_errno; > + }