From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing function
Date: Wed, 7 Jun 2017 06:12:05 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5CCBCD@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E0131FC3969@SHSMSX101.ccr.corp.intel.com>
> -----Original Message-----
> From: Xing, Beilei
> Sent: Wednesday, June 7, 2017 2:07 PM
> To: Lu, Wenzhuo; Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing function
>
>
>
> > -----Original Message-----
> > From: Lu, Wenzhuo
> > Sent: Wednesday, June 7, 2017 1:46 PM
> > To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org
> > Subject: RE: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing
> > function
> >
> > Hi Beilei,
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> > > Sent: Thursday, June 1, 2017 2:57 PM
> > > To: Wu, Jingjing
> > > Cc: dev@dpdk.org
> > > Subject: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing
> > > function
> > >
> > > This patch adds NVGRE parsing function to support NVGRE classification.
> > >
> > > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > > ---
> > > drivers/net/i40e/i40e_flow.c | 271
> > > ++++++++++++++++++++++++++++++++++++++++++-
> > > 1 file changed, 269 insertions(+), 2 deletions(-)
>
> >
> > > +
> > > + break;
> > > + case RTE_FLOW_ITEM_TYPE_VLAN:
> > > + vlan_spec =
> > > + (const struct rte_flow_item_vlan *)item-
> > > >spec;
> > > + vlan_mask =
> > > + (const struct rte_flow_item_vlan *)item-
> > > >mask;
> > > + if (nvgre_flag) {
> > Why need to check nvgre_flag? Seems VLAN must be after NVGRE, so this
> > flag is always 1.
>
> It's used to distinguish outer mac or inner mac.
I know you need to add this flag for MAC. But I'm talking about VLAN. There's only inner VLAN. So, seems it's useless here.
next prev parent reply other threads:[~2017-06-07 6:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 9:20 [dpdk-dev] [PATCH] " Beilei Xing
2017-06-01 6:56 ` [dpdk-dev] [PATCH v2 0/2] net/i40e: extend tunnel filter support Beilei Xing
2017-06-01 6:56 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: optimize vxlan parsing function Beilei Xing
2017-06-07 3:27 ` Lu, Wenzhuo
2017-06-07 3:30 ` Yuanhan Liu
2017-06-07 4:21 ` Xing, Beilei
2017-06-01 6:56 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE " Beilei Xing
2017-06-07 5:46 ` Lu, Wenzhuo
2017-06-07 6:06 ` Xing, Beilei
2017-06-07 6:12 ` Lu, Wenzhuo [this message]
2017-06-07 6:22 ` Xing, Beilei
2017-06-07 6:53 ` [dpdk-dev] [PATCH v3 0/2] net/i40e: extend tunnel filter support Beilei Xing
2017-06-07 6:53 ` [dpdk-dev] [PATCH v3 1/2] net/i40e: optimize vxlan parsing function Beilei Xing
2017-06-07 6:53 ` [dpdk-dev] [PATCH v3 2/2] net/i40e: add NVGRE " Beilei Xing
2017-06-07 8:07 ` Lu, Wenzhuo
2017-06-08 10:28 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B5CCBCD@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).