From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 011541B1F6 for ; Wed, 11 Oct 2017 04:57:59 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2017 19:57:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,359,1503385200"; d="scan'208";a="321833497" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 10 Oct 2017 19:57:58 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Oct 2017 19:57:58 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Oct 2017 19:57:57 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Wed, 11 Oct 2017 10:57:56 +0800 From: "Lu, Wenzhuo" To: Yong Wang CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/ixgbe: fix uninitialized variable Thread-Index: AQHTMPezssKVHa1IOEabOYa/vqrUXKLeFqSQ Date: Wed, 11 Oct 2017 02:57:55 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B6C240A@shsmsx102.ccr.corp.intel.com> References: <1505791044-5322-1-git-send-email-wang.yong19@zte.com.cn> In-Reply-To: <1505791044-5322-1-git-send-email-wang.yong19@zte.com.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix uninitialized variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 02:58:00 -0000 Hi, > -----Original Message----- > From: Yong Wang [mailto:wang.yong19@zte.com.cn] > Sent: Tuesday, September 19, 2017 11:17 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Yong Wang > Subject: [PATCH] net/ixgbe: fix uninitialized variable >=20 > In func ixgbe_dev_link_update(), "link.link_autoneg" is used in func call > rte_ixgbe_dev_atomic_write_link_status(), but is uninitialized. >=20 > Signed-off-by: Yong Wang > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 9ca5cbc..971de0c 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3957,6 +3957,7 @@ static int > ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, > link.link_status =3D ETH_LINK_DOWN; > link.link_speed =3D 0; > link.link_duplex =3D ETH_LINK_HALF_DUPLEX; > + link.link_autoneg =3D ETH_LINK_AUTONEG; TBH, I don't find ixgbe uses this field. But this patch doesn't harm. Acked-by: Wenzhuo Lu > memset(&old, 0, sizeof(old)); > rte_ixgbe_dev_atomic_read_link_status(dev, &old); >=20 > -- > 1.8.3.1