* [dpdk-dev] [PATCH] net/ixgbe: fix uninitialized variable
@ 2017-09-19 3:17 Yong Wang
2017-10-11 2:57 ` Lu, Wenzhuo
0 siblings, 1 reply; 3+ messages in thread
From: Yong Wang @ 2017-09-19 3:17 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: dev, Yong Wang
In func ixgbe_dev_link_update(), "link.link_autoneg" is used in func
call rte_ixgbe_dev_atomic_write_link_status(), but is uninitialized.
Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 9ca5cbc..971de0c 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3957,6 +3957,7 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
link.link_status = ETH_LINK_DOWN;
link.link_speed = 0;
link.link_duplex = ETH_LINK_HALF_DUPLEX;
+ link.link_autoneg = ETH_LINK_AUTONEG;
memset(&old, 0, sizeof(old));
rte_ixgbe_dev_atomic_read_link_status(dev, &old);
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix uninitialized variable
2017-09-19 3:17 [dpdk-dev] [PATCH] net/ixgbe: fix uninitialized variable Yong Wang
@ 2017-10-11 2:57 ` Lu, Wenzhuo
2017-10-11 22:53 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Lu, Wenzhuo @ 2017-10-11 2:57 UTC (permalink / raw)
To: Yong Wang; +Cc: dev
Hi,
> -----Original Message-----
> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
> Sent: Tuesday, September 19, 2017 11:17 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>
> Subject: [PATCH] net/ixgbe: fix uninitialized variable
>
> In func ixgbe_dev_link_update(), "link.link_autoneg" is used in func call
> rte_ixgbe_dev_atomic_write_link_status(), but is uninitialized.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 9ca5cbc..971de0c 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3957,6 +3957,7 @@ static int
> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
> link.link_status = ETH_LINK_DOWN;
> link.link_speed = 0;
> link.link_duplex = ETH_LINK_HALF_DUPLEX;
> + link.link_autoneg = ETH_LINK_AUTONEG;
TBH, I don't find ixgbe uses this field. But this patch doesn't harm.
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> memset(&old, 0, sizeof(old));
> rte_ixgbe_dev_atomic_read_link_status(dev, &old);
>
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix uninitialized variable
2017-10-11 2:57 ` Lu, Wenzhuo
@ 2017-10-11 22:53 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-10-11 22:53 UTC (permalink / raw)
To: Lu, Wenzhuo, Yong Wang; +Cc: dev
On 10/11/2017 3:57 AM, Lu, Wenzhuo wrote:
> Hi,
>
>> -----Original Message-----
>> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
>> Sent: Tuesday, September 19, 2017 11:17 AM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
>> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>
>> Subject: [PATCH] net/ixgbe: fix uninitialized variable
>>
>> In func ixgbe_dev_link_update(), "link.link_autoneg" is used in func call
>> rte_ixgbe_dev_atomic_write_link_status(), but is uninitialized.
>>
>> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-11 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-19 3:17 [dpdk-dev] [PATCH] net/ixgbe: fix uninitialized variable Yong Wang
2017-10-11 2:57 ` Lu, Wenzhuo
2017-10-11 22:53 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).