From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 120131B1A7 for ; Tue, 9 Jan 2018 12:44:48 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 03:44:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,335,1511856000"; d="scan'208";a="9320952" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 09 Jan 2018 03:44:47 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 03:44:47 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 03:44:47 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Tue, 9 Jan 2018 19:44:45 +0800 From: "Lu, Wenzhuo" To: Shahaf Shuler , "Wu, Jingjing" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight VLAN configuration Thread-Index: AQHTfi6Vi7NpD7XKIEWkyN9MCkzJTqNrQSuA//+enoCAAKBCoA== Date: Tue, 9 Jan 2018 11:44:44 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B70CA09@shsmsx102.ccr.corp.intel.com> References: <6A0DE07E22DDAD4C9103DF62FEBC09093B70C5D9@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmZhNWJkMjktMDY0OC00OTczLTlhMGUtZmRhZjNmYWUxZWU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InV2NzQ0KzdBZHVYa01oQU5hdWtxWkx6dHVQd0tMbk1IWlZqcU5lTHFGNG89In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight VLAN configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 11:44:49 -0000 Hi Shahaf, > -----Original Message----- > From: Shahaf Shuler [mailto:shahafs@mellanox.com] > Sent: Tuesday, January 9, 2018 6:04 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight > VLAN configuration >=20 > Tuesday, January 9, 2018 10:06 AM, Lu, Wenzhuo: > > > Subject: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight > > > VLAN configuration > > > > > > On ethdev there is an API to configure VLAN offloads after the port > > > was started and without reconfiguration of the port or queues. > > > > > > In the current design of the application, when the Rx offloads are > > > changed (through "port config all" CLI command) the port > > > configuration is overwritten, therefore the configuration made for th= e > VLAN is lost. > > > > > > This patch is to address the issue by a configuration of each port > > > Rx offloads separately instead of using the global Rx config. > > > > > > Fixes: 6dbb2b336586 ("app/testpmd: convert to new Ethdev Rx offloads > > > API") > > This patch is not applied yet. The number 6dbb2b336586 could be > > meaningless. If the previous patch need to be fixed, may I suggest > > just merge this one to that? Or this patch fixes some older issues actu= ally? >=20 > Well, this was done per Ferruh's request to better split the patches. >=20 > I can merge it with the Rx one, agreed? I think this patch fixes the bug in the old code. This bug is not introduce= d by "app/testpmd: convert to new Ethdev Rx offloads API". You set this fix= es tag only because the code is changed so much by "app/testpmd: convert to= new Ethdev Rx offloads API". It's helpful to create an individual patch. T= o my opinion, just remove the fixes tag is enough.