From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5665F1B1BC for ; Tue, 9 Jan 2018 12:51:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 03:51:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,335,1511856000"; d="scan'208";a="19510143" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 09 Jan 2018 03:51:07 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 03:51:07 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 03:51:07 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Tue, 9 Jan 2018 19:51:05 +0800 From: "Lu, Wenzhuo" To: Shahaf Shuler , "Wu, Jingjing" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags Thread-Index: AQHTfi5xj84d/zeyvUyXqCb0dr+qlaNrNpsw//+qQ4CAAKJDgA== Date: Tue, 9 Jan 2018 11:51:05 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B70CA59@shsmsx102.ccr.corp.intel.com> References: <079c2831ae6d80d105d7faf548a5683d965459e1.1514281260.git.shahafs@mellanox.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B70C54B@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 11:51:09 -0000 Hi Shahaf, > -----Original Message----- > From: Shahaf Shuler [mailto:shahafs@mellanox.com] > Sent: Tuesday, January 9, 2018 6:08 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags >=20 > Tuesday, January 9, 2018 9:17 AM, Lu, Wenzhuo: >=20 > --Shahaf >=20 >=20 > > -----Original Message----- > > From: Lu, Wenzhuo [mailto:wenzhuo.lu@intel.com] > > Sent: Tuesday, January 9, 2018 9:17 AM > > To: Shahaf Shuler ; Wu, Jingjing > > ; Yigit, Ferruh > > Cc: dev@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags > > > > Hi Shahaf, > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler > > > Sent: Tuesday, December 26, 2017 5:44 PM > > > To: Wu, Jingjing ; Yigit, Ferruh > > > > > > Cc: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags > > > > > > Since testpmd is now using the new Ethdev offloads API and there is > > > a way configure each of the tx offloads from CLI or command line, > > > there is no need for the txqflags configuration anymore. > > > > > > Signed-off-by: Shahaf Shuler > > > Acked-by: Nelio Laranjeiro > > > > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > > 806548196..91dcb31c0 100644 > > > --- a/app/test-pmd/testpmd.c > > > +++ b/app/test-pmd/testpmd.c > > > @@ -259,11 +259,6 @@ int16_t tx_free_thresh =3D > > RTE_PMD_PARAM_UNSET; > > > int16_t tx_rs_thresh =3D RTE_PMD_PARAM_UNSET; > > > > > > /* > > > - * Configurable value of TX queue flags. > > > - */ > > > -int32_t txq_flags =3D RTE_PMD_PARAM_UNSET; > > > - > > > -/* > > > * Receive Side Scaling (RSS) configuration. > > > */ > > > uint64_t rss_hf =3D ETH_RSS_IP; /* RSS IP by default. */ @@ -2084,9 > > > +2079,6 @@ rxtx_port_config(struct rte_port *port) > > > > > > if (tx_free_thresh !=3D RTE_PMD_PARAM_UNSET) > > > port->tx_conf.tx_free_thresh =3D tx_free_thresh; > > > - > > > - if (txq_flags !=3D RTE_PMD_PARAM_UNSET) > > > - port->tx_conf.txq_flags =3D txq_flags; > > I think we have some problem if just remove this code. Because port- > > >tx_conf.txq_flags is used by many NICs. If txqflags is removed, all > > >these > > NICs have to use the default value and have no chance to change it. I > > think it's a good idea to use tx-offloads to replace txqflags, but we > > may need to clear the drivers' code first. >=20 > There is an internal function in ethdev which do translation from the Tx > offloads to the txqflags. Checkout ``rte_eth_convert_txq_offloads``. > This is specifically to support PMDs which still use the old offloads API= . >=20 > So in fact application needs only to specify the Tx offloads on the tx_co= nf > and those will be converted to txqflags. The PMD see no difference. Yes, you're right, the convert code is already merged. Acked-by: Wenzhuo Lu