From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id B5EDE44C3 for ; Mon, 15 Jan 2018 04:30:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2018 19:30:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,361,1511856000"; d="scan'208";a="10020811" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 14 Jan 2018 19:30:17 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 14 Jan 2018 19:30:17 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 14 Jan 2018 19:30:17 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Mon, 15 Jan 2018 11:30:15 +0800 From: "Lu, Wenzhuo" To: Shahaf Shuler , "Wu, Jingjing" , "thomas@monjalon.net" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 10/11] app/testpmd: adjust on the flight VLAN configuration Thread-Index: AQHTifMqJmAWSLOnoEmnzKGHebMtDqN0TkgA Date: Mon, 15 Jan 2018 03:30:15 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B710793@shsmsx102.ccr.corp.intel.com> References: <20171123120804.143897-1-shahafs@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 10/11] app/testpmd: adjust on the flight VLAN configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 03:30:27 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Wednesday, January 10, 2018 5:09 PM > To: Wu, Jingjing ; thomas@monjalon.net; Yigit, > Ferruh > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v4 10/11] app/testpmd: adjust on the flight VL= AN > configuration >=20 > On ethdev there is an API to configure VLAN offloads after the port was > started and without reconfiguration of the port or queues. >=20 > In the current design of the application, when the Rx offloads are change= d > (through "port config all" CLI command) the port configuration is overwri= tten, > therefore the configuration made for the VLAN is lost. >=20 > This patch is to address the issue by a configuration of each port Rx off= loads > separately instead of using the global Rx config. Such adjustment is requ= ired > due to the conversion of the application to the new offloads API. >=20 > Signed-off-by: Shahaf Shuler Acked-by: Wenzhuo Lu