From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4BF6837B4 for ; Tue, 16 Jan 2018 07:06:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2018 22:06:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,367,1511856000"; d="scan'208";a="10047111" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 15 Jan 2018 22:06:53 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 15 Jan 2018 22:06:53 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 15 Jan 2018 22:06:53 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Tue, 16 Jan 2018 14:06:51 +0800 From: "Lu, Wenzhuo" To: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "Wu, Jingjing" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "Yigit, Ferruh" , "thomas@monjalon.net" , "olivier.matz@6wind.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 3/3] app/testpmd: set preferred mempool as default pktpool Thread-Index: AQHTdEyNG77gqTurUU+geMA+S9uM7KN2N4ZQ Date: Tue, 16 Jan 2018 06:06:50 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B711113@shsmsx102.ccr.corp.intel.com> References: <20171213195538.14290-1-pbhagavatula@caviumnetworks.com> <20171213195538.14290-4-pbhagavatula@caviumnetworks.com> In-Reply-To: <20171213195538.14290-4-pbhagavatula@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: set preferred mempool as default pktpool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 06:06:55 -0000 Hi Pavan, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pavan Nikhilesh > Sent: Thursday, December 14, 2017 3:56 AM > To: jerin.jacob@caviumnetworks.com; Wu, Jingjing ; > Richardson, Bruce ; hemant.agrawal@nxp.com; > Yigit, Ferruh ; thomas@monjalon.net; > olivier.matz@6wind.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 3/3] app/testpmd: set preferred mempool as > default pktpool >=20 > Set the mempool preferred by the ethernet devices as default mbuf > mempool before creating the pktpool. >=20 > Signed-off-by: Pavan Nikhilesh > --- > app/test-pmd/testpmd.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > c3ab44849..bfea35613 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -533,6 +533,8 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned > nb_mbuf, > rte_mempool_obj_iter(rte_mp, rte_pktmbuf_init, NULL); > } else { > /* wrapper to rte_mempool_create() */ > + RTE_LOG(INFO, USER1, "preferred mempool ops %s > selected\n", > + rte_eth_dev_get_preferred_pool_name(1)); This '1' looks like hardcode. May I suggest to change it to 'true'?