From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id BFC7A5F6E; Fri, 9 Mar 2018 09:45:27 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2018 00:45:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,444,1515484800"; d="scan'208";a="26557150" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 09 Mar 2018 00:45:25 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 9 Mar 2018 00:45:25 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 9 Mar 2018 00:45:25 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.80]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.166]) with mapi id 14.03.0319.002; Fri, 9 Mar 2018 16:45:23 +0800 From: "Lu, Wenzhuo" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "Glynn, Michael J" , "Zhang, Roy Fan" , "stable@dpdk.org" , "Zhang, Helin" , "Liang, Cunming" , "Chilikin, Andrey" Thread-Topic: [dpdk-dev] [PATCH v2] drivers/i40e: fix link update no wait Thread-Index: AQHTttgIPSHRSeP0wUunpobqJw/9NaPHmAlw Date: Fri, 9 Mar 2018 08:45:22 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B749EDA@shsmsx102.ccr.corp.intel.com> References: <20180308115524.70244-1-roy.fan.zhang@intel.com> <20180308121752.70424-1-roy.fan.zhang@intel.com> In-Reply-To: <20180308121752.70424-1-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] drivers/i40e: fix link update no wait X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2018 08:45:28 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > Sent: Thursday, March 8, 2018 8:18 PM > To: dev@dpdk.org > Cc: Glynn, Michael J ; Zhang, Roy Fan > ; stable@dpdk.org; Zhang, Helin > ; Liang, Cunming ; > Chilikin, Andrey > Subject: [dpdk-dev] [PATCH v2] drivers/i40e: fix link update no wait >=20 > Fixes: 263333bbb7a9 ("i40e: fix link status timeout") > Cc: cunming.liang@intel.com > Cc: stable@dpdk.org >=20 > In i40e_dev_link_update() the driver obtains the link status info via adm= in > queue command despite of "no_wait" flag. This requires relatively long ti= me > and may be a problem to some application such as ovs-dpdk > (https://bugzilla.redhat.com/show_bug.cgi?id=3D1551761). >=20 > This patch aims to fix the problem by using a different approach of obtai= ning > link status for i40e NIC without waiting. > Instead of getting the link status via admin queue command, this patch > reads the link status registers to accelerate the procedure. >=20 > Signed-off-by: Fan Zhang > Signed-off-by: Andrey Chilikin Acked-by: Wenzhuo Lu