From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E3F4D8DA9; Wed, 9 May 2018 07:24:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2018 22:24:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,380,1520924400"; d="scan'208";a="39804228" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 08 May 2018 22:24:32 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 8 May 2018 22:24:31 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 8 May 2018 22:24:31 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.79]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.40]) with mapi id 14.03.0319.002; Wed, 9 May 2018 13:24:29 +0800 From: "Lu, Wenzhuo" To: "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/avf: fix Rx interrupt mapping Thread-Index: AQHT4o1tUxYSwCl+HkSUQeyEPfrfFaQczOyAgAoZdzA= Date: Wed, 9 May 2018 05:24:29 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B798D6F@shsmsx102.ccr.corp.intel.com> References: <1525316935-108339-1-git-send-email-jingjing.wu@intel.com> <1525316935-108339-2-git-send-email-jingjing.wu@intel.com> In-Reply-To: <1525316935-108339-2-git-send-email-jingjing.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/avf: fix Rx interrupt mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 05:24:36 -0000 Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, May 3, 2018 11:09 AM > To: Lu, Wenzhuo > Cc: Wu, Jingjing ; dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/avf: fix Rx interrupt mapping >=20 > Vector used for rx mapping is different if WB_ON_ITR is supported. The > mapping table need to be updated. >=20 > Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") >=20 > Signed-off-by: Jingjing Wu > Cc: stable@dpdk.org > --- > drivers/net/avf/avf_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c = index > a1ae3a2..db0eda4 100644 > --- a/drivers/net/avf/avf_ethdev.c > +++ b/drivers/net/avf/avf_ethdev.c > @@ -339,13 +339,13 @@ static int avf_config_rx_queues_irqs(struct > rte_eth_dev *dev, > AVF_WRITE_FLUSH(hw); > /* map all queues to the same interrupt */ > for (i =3D 0; i < dev->data->nb_rx_queues; i++) > - vf->rxq_map[0] |=3D 1 << i; > + vf->rxq_map[vf->msix_base] |=3D 1 << i; > } else { > if (!rte_intr_allow_others(intr_handle)) { > vf->nb_msix =3D 1; > vf->msix_base =3D AVF_MISC_VEC_ID; > for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > - vf->rxq_map[0] |=3D 1 << i; > + vf->rxq_map[AVF_MISC_VEC_ID] |=3D 1 << i; Looks better using " vf->msix_base" here too. > intr_handle->intr_vec[i] =3D AVF_MISC_VEC_ID; > } > PMD_DRV_LOG(DEBUG, Better updating the debug log either. > -- > 2.4.11