From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 4E60C1B1F7 for ; Mon, 9 Jul 2018 09:38:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2018 00:38:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,329,1526367600"; d="scan'208";a="63246483" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jul 2018 00:38:04 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Jul 2018 00:38:04 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Jul 2018 00:38:03 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.81]) with mapi id 14.03.0319.002; Mon, 9 Jul 2018 15:38:02 +0800 From: "Lu, Wenzhuo" To: "Guo, Jia" , "stephen@networkplumber.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "gaetan.rivet@6wind.com" , "Wu, Jingjing" , "thomas@monjalon.net" , "motih@mellanox.com" , "matan@mellanox.com" , "Van Haaren, Harry" , "Zhang, Qi Z" , "He, Shaopeng" , "Iremonger, Bernard" , "arybchenko@solarflare.com" CC: "jblunck@infradead.org" , "shreyansh.jain@nxp.com" , "dev@dpdk.org" , "Guo, Jia" , "Zhang, Helin" Thread-Topic: [dpdk-dev] [PATCH v2 1/3] net/ixgbe: enable hotplug detect in ixgbe Thread-Index: AQHUF1J4xq19yh6t7UCZJvN9Tjtv9KSGf7qA Date: Mon, 9 Jul 2018 07:38:01 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B800FC5@shsmsx102.ccr.corp.intel.com> References: <1530787185-5915-1-git-send-email-jia.guo@intel.com> <1531119413-17298-1-git-send-email-jia.guo@intel.com> <1531119413-17298-2-git-send-email-jia.guo@intel.com> In-Reply-To: <1531119413-17298-2-git-send-email-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/ixgbe: enable hotplug detect in ixgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 07:38:24 -0000 Hi Jeff, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jeff Guo > Sent: Monday, July 9, 2018 2:57 PM > To: stephen@networkplumber.org; Richardson, Bruce > ; Yigit, Ferruh ; > Ananyev, Konstantin ; > gaetan.rivet@6wind.com; Wu, Jingjing ; > thomas@monjalon.net; motih@mellanox.com; matan@mellanox.com; Van > Haaren, Harry ; Zhang, Qi Z > ; He, Shaopeng ; > Iremonger, Bernard ; > arybchenko@solarflare.com > Cc: jblunck@infradead.org; shreyansh.jain@nxp.com; dev@dpdk.org; Guo, > Jia ; Zhang, Helin > Subject: [dpdk-dev] [PATCH v2 1/3] net/ixgbe: enable hotplug detect in ix= gbe >=20 > This patch aim to enable hotplug detect in ixgbe pmd driver. Firstly it s= et the > flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug ability, > and then use rte_dev_event_callback_register to register the hotplug even= t > callback to eal. When eal detect the hotplug event, it will call the call= back to > process it, if the event is hotplug remove, it will trigger the > RTE_ETH_EVENT_INTR_RMV event into ethdev callback to let app process > the hotplug for the ethdev. >=20 > This is an example for other driver, that if any driver support hotplug f= eature > could be use this way to enable hotplug detect. >=20 > Signed-off-by: Jeff Guo > --- > v2->v1: > refine some doc. > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 46 > +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 45 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 87d2ad0..83ce026 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -1534,6 +1534,47 @@ generate_random_mac_addr(struct ether_addr > *mac_addr) > memcpy(&mac_addr->addr_bytes[3], &random, 3); } >=20 > +static void > +eth_dev_event_callback(char *device_name, enum rte_dev_event_type > type, > + __rte_unused void *arg) > +{ > + uint32_t pid; > + > + if (type >=3D RTE_DEV_EVENT_MAX) { > + fprintf(stderr, "%s called upon invalid event %d\n", > + __func__, type); > + fflush(stderr); > + } > + > + switch (type) { > + case RTE_DEV_EVENT_REMOVE: > + PMD_DRV_LOG(INFO, "The device: %s has been removed!\n", > + device_name); > + > + if (!device_name) > + return; > + > + for (pid =3D 0; pid < RTE_MAX_ETHPORTS; pid++) { > + if (rte_eth_devices[pid].device) { > + if (!strcmp(device_name, > + rte_eth_devices[pid].device->name)) { > + _rte_eth_dev_callback_process( > + &rte_eth_devices[pid], > + RTE_ETH_EVENT_INTR_RMV, > NULL); > + continue; > + } > + } > + } > + break; > + case RTE_DEV_EVENT_ADD: > + RTE_LOG(INFO, EAL, "The device: %s has been added!\n", > + device_name); > + break; > + default: > + break; > + } > +} I don't get the point. Looks like this's a very common rte code. Why is it = put in ixgbe pmd?