From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Stokes, Ian" <ian.stokes@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Stokes, Ian" <ian.stokes@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: Support mtu set for igbvf.
Date: Tue, 10 Jul 2018 01:03:38 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B8027C1@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1530280253-10370-1-git-send-email-ian.stokes@intel.com>
Hi Ian,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ian Stokes
> Sent: Friday, June 29, 2018 9:51 PM
> To: dev@dpdk.org
> Cc: Stokes, Ian <ian.stokes@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/e1000: Support mtu set for igbvf.
>
> This patch enables setting the MTU of an igbvf device by re-using the
> eth_igb_mtu_set() in igbvf_eth_dev_ops.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> ---
> drivers/net/e1000/igb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index edc7be3..650e831 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -442,6 +442,7 @@ static const struct eth_dev_ops igbvf_eth_dev_ops =
> {
> .txq_info_get = igb_txq_info_get,
> .mac_addr_set = igbvf_default_mac_addr_set,
> .get_reg = igbvf_get_regs,
> + .mtu_set = eth_igb_mtu_set,
I think "eth_igb_mtu_set" is PF specific function that cannot be used on VF. As it touches PF specific registers.
Looks like MTU setting even not supported by igb VF.
next prev parent reply other threads:[~2018-07-10 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 13:50 Ian Stokes
2018-07-10 1:03 ` Lu, Wenzhuo [this message]
2018-07-11 12:24 ` Ian Stokes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B8027C1@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).