From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix little perf drop with XL710
Date: Thu, 12 Jul 2018 05:56:14 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B803A5C@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1531275335-29234-1-git-send-email-xiaoyun.li@intel.com>
Hi Xiaoyun,
> -----Original Message-----
> From: Li, Xiaoyun
> Sent: Wednesday, July 11, 2018 10:16 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] app/testpmd: fix little perf drop with XL710
>
> There is about 1.8M perf drop with XL710. And it is because of a bitrate
What's 1.8M mean? BPS? PPS?
Looks like this patch fixes the CPU consuming problem and has nothing to do with a specific NIC.
2 suggestions.
Just omit XL710, also in the tittle.
Maybe better mentioning how many percent drop but not an accurate number.
Except that, Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> calculation in the datapath. So improve it by maintaining an array of port
> indexes in testpmd, which is updated with ethdev events.
>
> Fixes: 8728ccf37615 ("fix ethdev ports enumeration")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
next prev parent reply other threads:[~2018-07-12 5:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 2:28 [dpdk-dev] [PATCH] " Xiaoyun Li
2018-07-10 4:31 ` Zhang, Qi Z
2018-07-11 2:15 ` [dpdk-dev] [PATCH v2] " Xiaoyun Li
2018-07-12 4:56 ` Zhang, Qi Z
2018-07-12 5:56 ` Lu, Wenzhuo [this message]
2018-07-12 8:01 ` Li, Xiaoyun
2018-07-12 7:55 ` [dpdk-dev] [PATCH v3] app/testpmd: fix little perf drop Xiaoyun Li
2018-07-16 3:02 ` Lu, Wenzhuo
2018-07-18 10:10 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B803A5C@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).