From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9B06A1B3A2; Thu, 2 Aug 2018 03:57:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2018 18:57:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,434,1526367600"; d="scan'208";a="62647929" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga006.jf.intel.com with ESMTP; 01 Aug 2018 18:57:11 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 18:57:05 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 18:57:05 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.81]) with mapi id 14.03.0319.002; Thu, 2 Aug 2018 09:56:24 +0800 From: "Lu, Wenzhuo" To: "Li, Xiaoyun" , "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/avf: fix missing offload capabilities Thread-Index: AQHUI+gQ9f5UYNvsxkiwXAG6bK2KbaSqIt8g//9+y4CAAh5MEA== Date: Thu, 2 Aug 2018 01:56:24 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B80C4C2@shsmsx102.ccr.corp.intel.com> References: <1532502870-448711-1-git-send-email-xiaoyun.li@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B80C02C@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/avf: fix missing offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 01:57:35 -0000 Hi Xiaoyun, > -----Original Message----- > From: Li, Xiaoyun > Sent: Wednesday, August 1, 2018 9:35 AM > To: Lu, Wenzhuo ; Wu, Jingjing > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] net/avf: fix missing offload capabilities >=20 > Hi >=20 > > -----Original Message----- > > From: Lu, Wenzhuo > > Sent: Wednesday, August 1, 2018 09:19 > > To: Li, Xiaoyun ; Wu, Jingjing > > > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: RE: [PATCH] net/avf: fix missing offload capabilities > > > > Hi Xiaoyun, > > > > > > > -----Original Message----- > > > From: Li, Xiaoyun > > > Sent: Wednesday, July 25, 2018 3:15 PM > > > To: Lu, Wenzhuo ; Wu, Jingjing > > > > > > Cc: dev@dpdk.org; Li, Xiaoyun ; > > > stable@dpdk.org > > > Subject: [PATCH] net/avf: fix missing offload capabilities > > > > > > There are several tx/rx offload capabilities missing in AVF. > > > Add them in this patch since AVF supports them. > > > > > > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Xiaoyun Li > > > --- > > > drivers/net/avf/avf_ethdev.c | 18 ++++++++++++++++-- > > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/net/avf/avf_ethdev.c > > > b/drivers/net/avf/avf_ethdev.c index 0e21f8c..3a2baaf 100644 > > > --- a/drivers/net/avf/avf_ethdev.c > > > +++ b/drivers/net/avf/avf_ethdev.c > > > @@ -518,16 +518,30 @@ avf_dev_info_get(struct rte_eth_dev *dev, > > > struct rte_eth_dev_info *dev_info) > > > dev_info->max_mac_addrs =3D AVF_NUM_MACADDR_MAX; > > > dev_info->rx_offload_capa =3D > > > DEV_RX_OFFLOAD_VLAN_STRIP | > > > + DEV_RX_OFFLOAD_QINQ_STRIP | > > > DEV_RX_OFFLOAD_IPV4_CKSUM | > > > DEV_RX_OFFLOAD_UDP_CKSUM | > > > - DEV_RX_OFFLOAD_TCP_CKSUM; > > > + DEV_RX_OFFLOAD_TCP_CKSUM | > > > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > > > + DEV_RX_OFFLOAD_CRC_STRIP | > > > + DEV_RX_OFFLOAD_KEEP_CRC | > > Don't find this flag. Does this path depend on another? > > Do we need to announce this capa? >=20 > You mean KEEP_CRC? I copy the flags from i40evf. > In release note: > In v18.11 ``DEV_RX_OFFLOAD_CRC_STRIP`` offload flag will be removed, > default > behavior without any flag will be changed to CRC strip. > To keep CRC ``DEV_RX_OFFLOAD_KEEP_CRC`` flag is required. > ``KEEP_CRC``: Keep CRC in packet > No flag: Strip CRC from packet O, got the history. Acked-by: Wenzhuo Lu >=20 > > > > > + DEV_RX_OFFLOAD_SCATTER | > > > + DEV_RX_OFFLOAD_JUMBO_FRAME | > > > + DEV_RX_OFFLOAD_VLAN_FILTER; > > > dev_info->tx_offload_capa =3D > > > DEV_TX_OFFLOAD_VLAN_INSERT | > > > + DEV_TX_OFFLOAD_QINQ_INSERT | > > > DEV_TX_OFFLOAD_IPV4_CKSUM | > > > DEV_TX_OFFLOAD_UDP_CKSUM | > > > DEV_TX_OFFLOAD_TCP_CKSUM | > > > DEV_TX_OFFLOAD_SCTP_CKSUM | > > > - DEV_TX_OFFLOAD_TCP_TSO; > > > + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | > > > + DEV_TX_OFFLOAD_TCP_TSO | > > > + DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > > > + DEV_TX_OFFLOAD_GRE_TNL_TSO | > > > + DEV_TX_OFFLOAD_IPIP_TNL_TSO | > > > + DEV_TX_OFFLOAD_GENEVE_TNL_TSO | > > > + DEV_TX_OFFLOAD_MULTI_SEGS; > > > > > > dev_info->default_rxconf =3D (struct rte_eth_rxconf) { > > > .rx_free_thresh =3D AVF_DEFAULT_RX_FREE_THRESH, > > > -- > > > 2.7.4