From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E75C71B147 for ; Wed, 5 Dec 2018 09:19:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2018 00:19:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,317,1539673200"; d="scan'208";a="125216120" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 05 Dec 2018 00:19:49 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 5 Dec 2018 00:19:49 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.182]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0415.000; Wed, 5 Dec 2018 16:19:47 +0800 From: "Lu, Wenzhuo" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 00/19] A new net PMD - ice Thread-Index: AQHUgvj/iEqOCrnweUi4L6TVUoFD1qVcq1CAgBMYL1D//4i0AIAAkmVw Date: Wed, 5 Dec 2018 08:19:46 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093FE1132E@shsmsx102.ccr.corp.intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <2482097.kNToWcbbbU@xps> <6A0DE07E22DDAD4C9103DF62FEBC09093FE11281@shsmsx102.ccr.corp.intel.com> <4582980.XP1efssEEA@xps> In-Reply-To: <4582980.XP1efssEEA@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 00/19] A new net PMD - ice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 08:19:51 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, December 5, 2018 3:29 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 00/19] A new net PMD - ice >=20 > 05/12/2018 07:39, Lu, Wenzhuo: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 23/11/2018 07:56, Wenzhuo Lu: > > > > net/ice: add base code > > > > > > This first patch is really too big. > > > Please could you try to split it logically? > > > > This is base code which is not developed by us. We're not so familiar w= ith > it. It's the first time to release the code, I know it's too big, to us t= oo. But > anyway we'll maintain it. > > To save the effort, we always don't split the base code when releasing = it at > the first time. Is that OK? >=20 > It's not the best start. > How a very new driver can start with so many code and not being fully > understood by those who will maintain it? >=20 > It's really better to start small and grow. > It would ease both testing and understanding. Agree ideally it's much better if I can understand the whole code. But ther= e's about 26K lines of code. I cannot lie to say I or any single person can= fully understand all of them. There's a team that's supporting us. If any = bug related to the code, we'll ask the help from the team. Even we found th= e root cause of the bug, we'd like getting confirm from them. That's how we= make it work for all our NICs.