From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E939D2C02 for ; Fri, 14 Dec 2018 01:37:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2018 16:37:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,350,1539673200"; d="scan'208";a="118684763" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 13 Dec 2018 16:37:42 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 16:37:42 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 16:37:41 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.182]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.210]) with mapi id 14.03.0415.000; Fri, 14 Dec 2018 08:37:40 +0800 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Yang, Qiming" , "Li, Xiaoyun" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v3 22/34] net/ice: support MAC ops Thread-Index: AQHUkefE5z6Czeo4mU+66JcsfAYg26V72p2AgAGLzYA= Date: Fri, 14 Dec 2018 00:37:39 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093FE13E03@shsmsx102.ccr.corp.intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <1544598004-27099-1-git-send-email-wenzhuo.lu@intel.com> <1544598004-27099-23-git-send-email-wenzhuo.lu@intel.com> <039ED4275CED7440929022BC67E70611532FE4FB@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611532FE4FB@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 22/34] net/ice: support MAC ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 00:37:44 -0000 Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, December 13, 2018 5:00 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Li, Xiaoyun ; Wu, Jingjing > > Subject: RE: [dpdk-dev] [PATCH v3 22/34] net/ice: support MAC ops >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Wednesday, December 12, 2018 3:00 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Yang, Qiming > > ; Li, Xiaoyun ; Wu, > > Jingjing > > Subject: [dpdk-dev] [PATCH v3 22/34] net/ice: support MAC ops > > > > Add below ops, > > mac_addr_set > > mac_addr_add > > mac_addr_remove > > > > Signed-off-by: Wenzhuo Lu > > Signed-off-by: Qiming Yang > > Signed-off-by: Xiaoyun Li > > Signed-off-by: Jingjing Wu >=20 > ..... >=20 >=20 > > --- > > drivers/net/ice/ice_ethdev.c | 233 > > +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 233 insertions(+) > > > > +static int ice_macaddr_set(struct rte_eth_dev *dev, > > + struct ether_addr *mac_addr) > > +{ > > + struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > + struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data- > >dev_private); > > + struct ice_vsi *vsi =3D pf->main_vsi; > > + struct ice_mac_filter *f; > > + uint8_t flags =3D 0; > > + int ret; > > + > > + if (!is_valid_assigned_ether_addr(mac_addr)) { > > + PMD_DRV_LOG(ERR, "Tried to set invalid MAC address."); > > + return -EINVAL; > > + } > > + > > + TAILQ_FOREACH(f, &vsi->mac_list, next) { > > + if (is_same_ether_addr(&pf->dev_addr, &f- > >mac_info.mac_addr)) > > + break; > > + } > > + > > + if (!f) { > > + PMD_DRV_LOG(ERR, "Failed to find filter for default mac"); > > + return -EIO; > > + } > > + > > + ret =3D ice_remove_mac_filter(vsi, &f->mac_info.mac_addr); > > + if (ret !=3D ICE_SUCCESS) { > > + PMD_DRV_LOG(ERR, "Failed to delete mac filter"); > > + return -EIO; > > + } > > + ret =3D ice_add_mac_filter(vsi, mac_addr); > > + if (ret !=3D ICE_SUCCESS) { > > + PMD_DRV_LOG(ERR, "Failed to add mac filter"); > > + return -EIO; > > + } > > + memcpy(&pf->dev_addr, mac_addr, ETH_ADDR_LEN); > > + > > + flags =3D ICE_AQC_MAN_MAC_UPDATE_LAA_WOL; > > + ice_aq_manage_mac_write(hw, mac_addr->addr_bytes, flags, NULL); >=20 > Should check return value of the AQ command in case some error happen? Good suggestion. I'll add an error print here. >=20 > > + > > + return 0; > > +} > > +