From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2800E1B5C9 for ; Fri, 14 Dec 2018 01:42:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2018 16:42:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,350,1539673200"; d="scan'208";a="125767056" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 13 Dec 2018 16:42:00 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 16:42:00 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 16:42:00 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.182]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0415.000; Fri, 14 Dec 2018 08:41:58 +0800 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Yang, Qiming" , "Li, Xiaoyun" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v3 18/34] net/ice: support getting device information Thread-Index: AQHUksOv6u/M5FrEuEq5ZQHmzeyEZaV9ZfYQ Date: Fri, 14 Dec 2018 00:41:58 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093FE13E17@shsmsx102.ccr.corp.intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <1544598004-27099-1-git-send-email-wenzhuo.lu@intel.com> <1544598004-27099-19-git-send-email-wenzhuo.lu@intel.com> <039ED4275CED7440929022BC67E70611532FE524@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611532FE524@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 18/34] net/ice: support getting device information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 00:42:02 -0000 Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, December 13, 2018 5:10 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Li, Xiaoyun ; Wu, Jingjing > > Subject: RE: [dpdk-dev] [PATCH v3 18/34] net/ice: support getting device > information >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Wednesday, December 12, 2018 3:00 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Yang, Qiming > > ; Li, Xiaoyun ; Wu, > > Jingjing > > Subject: [dpdk-dev] [PATCH v3 18/34] net/ice: support getting device > > information > > > > Add ops dev_infos_get. > > > > Signed-off-by: Wenzhuo Lu > > Signed-off-by: Qiming Yang > > Signed-off-by: Xiaoyun Li > > Signed-off-by: Jingjing Wu > > --- > > drivers/net/ice/ice_ethdev.c | 123 > > +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 123 insertions(+) > > >=20 > > } > > + > > +static void > > +ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info > > +*dev_info) { > > + struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data- > >dev_private); > > + struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > + struct ice_vsi *vsi =3D pf->main_vsi; > > + struct rte_pci_device *pci_dev =3D RTE_DEV_TO_PCI(dev->device); > > + > > + dev_info->min_rx_bufsize =3D ICE_BUF_SIZE_MIN; > > + dev_info->max_rx_pktlen =3D ICE_FRAME_SIZE_MAX; > > + dev_info->max_rx_queues =3D vsi->nb_qps; > > + dev_info->max_tx_queues =3D vsi->nb_qps; > > + dev_info->max_mac_addrs =3D vsi->max_macaddrs; > > + dev_info->max_vfs =3D pci_dev->max_vfs; > > + > > + dev_info->rx_offload_capa =3D > > + DEV_RX_OFFLOAD_VLAN_STRIP | > > + DEV_RX_OFFLOAD_IPV4_CKSUM | > > + DEV_RX_OFFLOAD_UDP_CKSUM | > > + DEV_RX_OFFLOAD_TCP_CKSUM | > > + DEV_RX_OFFLOAD_QINQ_STRIP | > > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > > + DEV_RX_OFFLOAD_VLAN_EXTEND | > > + DEV_RX_OFFLOAD_JUMBO_FRAME; >=20 > I think we missed some offload here which ice driver does support >=20 > Rx port offload > DEV_RX_OFFLOAD_KEEP_CRC > DEV_RX_OFFLOAD_SCATTER > DEV_RX_OFFLOAD_VLAN_FILTER >=20 > Tx queue offload > DEV_TX_OFFLOAD_MBUF_FAST_FREE Thanks. Will add it in v4. >=20 > > + dev_info->tx_offload_capa =3D > > + DEV_TX_OFFLOAD_VLAN_INSERT | > > + DEV_TX_OFFLOAD_QINQ_INSERT | > > + DEV_TX_OFFLOAD_IPV4_CKSUM | > > + DEV_TX_OFFLOAD_UDP_CKSUM | > > + DEV_TX_OFFLOAD_TCP_CKSUM | > > + DEV_TX_OFFLOAD_SCTP_CKSUM | > > + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | > > + DEV_TX_OFFLOAD_TCP_TSO; > > + dev_info->rx_queue_offload_capa =3D 0; > > + dev_info->tx_queue_offload_capa =3D 0; >=20 > > +